Polish codebase and fix issues #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
NikolayS
commented
Nov 5, 2025
NikolayS
commented
- Fix grammar in README.md: "incomplete list" → "an incomplete list"
- Improve README.md formatting for better readability
- Fix shell script formatting in generate.sh (add missing space)
- Update PostgreSQL terminology: "master" → "primary" in all SQL files
- Fix typos in SQL comments: "inspect" → "inspects", "Vaccuum" → "Vacuum"
- Remove duplicate random_page_cost entry in t1_tuning.sql
- Remove redundant CTE in i2_redundant_indexes.sql
- Regenerate start.psql file with updated changes
Documentation improvements:
- Fix grammar in README.md ("an incomplete list")
- Improve README.md formatting for better readability
Code quality improvements:
- Fix shell script formatting in generate.sh (spacing)
- Update terminology: "master" → "primary" throughout SQL files
- Fix typos: "inspect" → "inspects", "Vaccuum" → "Vacuum"
- Remove duplicate random_page_cost entry in t1_tuning.sql
- Remove redundant CTE in i2_redundant_indexes.sql
- Regenerate start.psql with updated changes
These changes improve code consistency and align with modern
PostgreSQL terminology while maintaining backward compatibility.
NikolayS
force-pushed
the
claude/polish-codebase-011CUqdAcdCrkXdiTHDz9zft
branch
from
bb9c89b to
f852239
Compare
Code quality improvements: - Fix typos in b2_btree_estimation.sql: - "inspect" → "inspects" - "filed" → "fields" - "fractionnal" → "fractional" - "functionnal" → "functional" - Fix typo in p1_alignment_padding.sql: "alt_shits" → "alt_shifts" - Improve comment readability in s2_pg_stat_statements_report.sql: - Add space after "--" for consistency - "format" → "formatting" for grammatical correctness These changes improve code documentation and fix embarrassing typos that could confuse developers reading the codebase.
Code improvements: - Fix alter_user script to use 'raise info' instead of 'raise debug' for consistency with create_user script - Fix inverted logic in refresh_all.sql notice message: - Change TRUE to FALSE for correct instruction - Replace "w/o" with "without" for better readability - Remove duplicate 'sum(calls) as calls' in s1_pg_stat_statements_top_total.sql that was defined both globally and in the \else block These changes fix functional issues and improve code clarity.
Code quality improvements: - Standardize comment formatting to include space after "--": - b3_table_pgstattuple.sql: Fix 4 comment lines - b4_btree_pgstattuple.sql: Fix 4 comment lines - l1_lock_trees.sql: Fix inline comment - v2_autovacuum_progress_and_queue.sql: Fix inline comment Bug fix: - l2_lock_trees.sql: Add ELSE clause to CASE statement to prevent NULL concatenation when level = 1, which would make the entire format() result NULL These changes ensure consistent comment formatting across SQL files and fix a subtle bug that could cause query results to be NULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.