Skip to content

Conversation

@sunnyqgg
Copy link
Collaborator

@sunnyqgg sunnyqgg commented Oct 31, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped test case to improve test coverage validation.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@sunnyqgg sunnyqgg requested a review from a team as a code owner October 31, 2025 05:34
@sunnyqgg sunnyqgg requested a review from EmmaQiaoCh October 31, 2025 05:34
@sunnyqgg sunnyqgg changed the title [https://nvbugs/5461796][fix] Unwaive test 5461796 [https://nvbugs/5461796][fix] Unwaive test Oct 31, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

📝 Walkthrough

Walkthrough

A test skip marker for accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_chunked_prefill was removed from the waives list, re-enabling execution of the previously skipped test.

Changes

Cohort / File(s) Summary
Test Skip Re-enablement
tests/integration/test_lists/waives.txt
Removed skip marker for TestQwen3_8B::test_chunked_prefill, effectively re-enabling the test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • mikeiovine

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description has not been meaningfully completed by the author. While the PR template structure is present, the critical sections remain unfilled: the PR title is missing (the objectives indicate it should be "[https://nvbugs/5461796][fix] Unwaive test 5461796"), the Description section explaining the issue and solution is empty, and the Test Coverage section listing relevant tests is empty. Only the final checklist checkbox was marked, while the actual content sections that should guide reviewers through the changes and intent are left blank. This constitutes a largely incomplete submission that does not meet the template requirements. The author should provide a complete PR description by filling in: (1) the PR title following the specified format with ticket ID and type, (2) a Description section explaining what test is being re-enabled, why it was previously skipped, and why it should now be unskipped, and (3) a Test Coverage section identifying the specific test that will verify this change (likely accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_chunked_prefill based on the raw summary). These sections are essential for code reviewers to understand the change scope and rationale.
Title Check ⚠️ Warning The PR title references "Unwaive test test_llmapi_speculative_decoding_mtp," but the actual changeset shows that the modification is to tests/integration/test_lists/waives.txt, which removes a skip marker for the test accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_chunked_prefill. The specific test name mentioned in the title does not match the test actually being modified in the changeset, making the title misleading and inaccurate about which test is being re-enabled. While the action ("unwaive") is correct, the test identity is wrong, which violates the requirement for clarity and accuracy in communicating the main change. The title should be corrected to reference the actual test being modified: test_chunked_prefill from TestQwen3_8B in accuracy/test_disaggregated_serving.py, rather than test_llmapi_speculative_decoding_mtp. A corrected title might be: "[https://nvbugs/5461796][fix] Unwaive test test_chunked_prefill" or similar, ensuring it accurately reflects the test being re-enabled in the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sunnyqgg
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23135 [ run ] triggered by Bot. Commit: ee21108

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23135 [ run ] completed with state SUCCESS. Commit: ee21108
/LLM/release-1.1/L0_MergeRequest_PR pipeline #328 completed with status: 'FAILURE'

@sunnyqgg
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23173 [ run ] triggered by Bot. Commit: ee21108

@sunnyqgg sunnyqgg changed the title [https://nvbugs/5461796][fix] Unwaive test [https://nvbugs/5461796][fix] Unwaive test test_llmapi_speculative_decoding_mtp Oct 31, 2025
@sunnyqgg
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23176 [ run ] triggered by Bot. Commit: d38d701

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23173 [ run ] completed with state ABORTED. Commit: ee21108
LLM/release-1.1/L0_MergeRequest_PR #337 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23176 [ run ] completed with state SUCCESS. Commit: d38d701
/LLM/release-1.1/L0_MergeRequest_PR pipeline #338 completed with status: 'FAILURE'

@sunnyqgg
Copy link
Collaborator Author

sunnyqgg commented Nov 1, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23244 [ run ] triggered by Bot. Commit: d38d701

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23244 [ run ] completed with state SUCCESS. Commit: d38d701
/LLM/release-1.1/L0_MergeRequest_PR pipeline #353 completed with status: 'FAILURE'

@sunnyqgg
Copy link
Collaborator Author

sunnyqgg commented Nov 1, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23248 [ run ] triggered by Bot. Commit: d38d701

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23248 [ run ] completed with state SUCCESS. Commit: d38d701
/LLM/release-1.1/L0_MergeRequest_PR pipeline #354 completed with status: 'FAILURE'

@sunnyqgg
Copy link
Collaborator Author

sunnyqgg commented Nov 1, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23250 [ run ] triggered by Bot. Commit: d38d701

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23250 [ run ] completed with state SUCCESS. Commit: d38d701
/LLM/release-1.1/L0_MergeRequest_PR pipeline #355 completed with status: 'FAILURE'

Signed-off-by: qgai <qgai@nvidia.com>
@sunnyqgg
Copy link
Collaborator Author

sunnyqgg commented Nov 3, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23305 [ run ] triggered by Bot. Commit: c244e59

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23305 [ run ] completed with state SUCCESS. Commit: c244e59
/LLM/release-1.1/L0_MergeRequest_PR pipeline #370 completed with status: 'FAILURE'

@sunnyqgg
Copy link
Collaborator Author

sunnyqgg commented Nov 3, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23341 [ run ] triggered by Bot. Commit: c244e59

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23341 [ run ] completed with state SUCCESS. Commit: c244e59
/LLM/release-1.1/L0_MergeRequest_PR pipeline #377 completed with status: 'SUCCESS'

@longlee0622 longlee0622 merged commit ccadb66 into NVIDIA:release/1.1 Nov 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants