Skip to content

Conversation

@liquor233
Copy link
Collaborator

@liquor233 liquor233 commented Oct 29, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Bump required nv-one-logger version to avoid a bug of duplicated file descriptors.

Collection: [Note which collection this PR will affect]

Changelog

  • Change nv-one-logger-* related packages version >=2.3.1

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Signed-off-by: liquor233 <jiashangh@nvidia.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum version requirements for three NVIDIA One Logger packages from 2.3.0 to 2.3.1.

  • Updated version constraints for nv_one_logger_core, nv_one_logger_training_telemetry, and nv_one_logger_pytorch_lightning_integration packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chtruong814
Copy link
Collaborator

we'll need to cherry-pick something else to resolve the install checks. I'll take care of that separately and merge this in.

@chtruong814 chtruong814 merged commit 79ad79f into r2.5.0 Oct 31, 2025
94 of 104 checks passed
@chtruong814 chtruong814 deleted the jiashang/update-dependency-version-for-fix-for-release branch October 31, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants