Skip to content

Conversation

@NickSzapiro-NOAA
Copy link

Description

One round of straight-forward fixes for some of the compiler warnings raised in compiling cpld_debug_gfsv17 to improve code quality and prepare for operational implementation

Part of ufs-community/ufs-weather-model#2703

How Has This Been Tested?

Tested via ufs-weather-model RTs and compile err logs with Intel and GNU compilers on Ursa

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@gspetro-NOAA
Copy link

If there are atmos_cubed_sphere code managers available to approve this PR, it would be very helpful. The parent WM PR #2935 needs to be processed soon for GFS v17 retros.

integer, intent(IN) :: is, ie, js, je, isd, ied, jsd, jed, npx, npy, npz, ng

integer :: i, j, k

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, we could also fix this in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants