fix: invalid revoke token #7012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lwin-kyaw
force-pushed
the
fix/revoke-token
branch
from
2f92c99 to
96b1644
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
smgv
previously approved these changes
Oct 30, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixed
Invalid Revoke Token.References
Checklist
Note
Makes revokeToken optional in authenticate, retrieves access/revoke tokens from vault when missing, hardens validation/expiry checks, and fixes InvalidRevokeToken during token refresh.
authenticateparamrevokeTokenoptional and stop passing it on refresh re-auth.#getAccessTokenAndRevokeToken(password)to source tokens from state or decryptedvault; throwInvalidAccessToken/InvalidRevokeTokenif absent.#createNewVaultWithAuthData; improve error logging.checkAccessTokenExpired.assertIsAuthUserInfoValidusage with#assertIsAuthenticatedUser.assertIsSeedlessOnboardingUserAuthenticated; remove revoke/access checks from auth assertion.revokeTokeninVaultDataand throw specific errors for missing/invalidaccessToken/revokeTokeninassertIsValidVaultData.revokeToken/accessTokenfromAuthenticatedUserDetailstype.refreshAuthTokens, re-authenticate with refreshed tokens withoutrevokeToken.CHANGELOG.mdwith the above changes and the fix forInvalidRevokeTokeninrefreshAuthTokens.Written by Cursor Bugbot for commit cc7e30d. This will update automatically on new commits. Configure here.