Meta+Everywhere: Fix OpenBSD support and add minor FreeBSD improvements #6589
+312
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's version getting pinned was missed when the dependency was added.
Other dependency have their port version pinned already but not this one.
I added the `bsd` platform expression recently in upstream vcpkg and this makes the file just a little bit cleaner and makes the work for supporting future BSD systems simpler.
cqundefine
force-pushed
the
openbsd_and_freebsd_improvements
branch
from
4cc4bbc to
1673ec9
Compare
trflynn89
reviewed
Oct 26, 2025
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWindowOrWorkerInterfaces.cpp
Outdated
Show resolved
Hide resolved
cqundefine
force-pushed
the
openbsd_and_freebsd_improvements
branch
from
1673ec9 to
c891e8c
Compare
trflynn89
reviewed
Oct 27, 2025
| @@ -0,0 +1,28 @@ | |||
| diff --git a/BUILD.gn b/BUILD.gn | |||
There was a problem hiding this comment.
Question - how does this compare with #6599? Is this commit meant to be a full version update to match upstream's skia port, or would we be partway in between versions?
There was a problem hiding this comment.
I ended up dropping that patch, as it was only some changes from the upstream update, that PR is a cleaner solution to this and does the same thing when it comes to BSD support. I will mark the PR as draft until that gets merged.
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWindowOrWorkerInterfaces.cpp
Show resolved
Hide resolved
cqundefine
force-pushed
the
openbsd_and_freebsd_improvements
branch
from
c891e8c to
9f538c6
Compare
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
This will be needed later for OpenBSD specific code. It also does break NetBSD and DragonFly on purpose as those systems are nowhere near close to building right now with this script and it's better to clearly state they are unsupported.
The bug doesn't only affect FreeBSD but the others too.
It turns out the problem present on FreeBSD is also present on OpenBSD.
This patch is more complete and closer to how BSD ports of chromium do it. It also contains one tiny fix to the WebKitCompilerFlags file.
This generator uses so much memory that it crosses the default OpenBSD limit.
OpenBSD really doesn't have a better way to get the executable path than guessing it based on argv[0] and the PATH environment variable. I also found that this is what many other projects with OpenBSD support do. While this method is not always gonna return the correct value this is enough to get Ladybird running.
Just as on FreeBSD, OpenBSD also has libdrm and DMA-BUF. This gets WebGL working on OpenBSD.
As noted in the error messages the cmake port on OpenBSD has some quirks (not creating namelinks) that break vcpkg. The old pkg-config is also just a simple perl script which is too primitive to work in all cases when using complicated systems like vcpkg.
cqundefine
force-pushed
the
openbsd_and_freebsd_improvements
branch
from
9f538c6 to
ca7da75
Compare
github-actions
bot
removed
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6599