LibWeb: implement the MediaSession API #6588
Open
+830
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd-dreams
force-pushed
the
mediasession-api
branch
from
29e209d to
7b7fd0f
Compare
Currently `set_microphone_active`, `set_camera_active` and `set_screenshare_active` are left unimplemented due to missing infrastructure.
dd-dreams
force-pushed
the
mediasession-api
branch
from
cf3e26a to
8bad2d0
Compare
dd-dreams
force-pushed
the
mediasession-api
branch
from
8bad2d0 to
f5bd398
Compare
dd-dreams
force-pushed
the
mediasession-api
branch
from
f5bd398 to
d8aff25
Compare
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
dd-dreams
force-pushed
the
mediasession-api
branch
from
256b3ec to
f271472
Compare
Also implement Play/Pause with Play/Pause key.
There are still some actions that are left to be implemented, but those are not in the scope of this commit (e.g. Next track). Currently they're implemented for MediaSession::setActionHandler, but they don't actually work yet. `fastSeek` attribute might not be used correctly here, because it's also out of scope.
In MediaMetadata artwork convergence.
dd-dreams
force-pushed
the
mediasession-api
branch
from
f271472 to
31d5c15
Compare
|
There might be some code linting that should be done, but first I would like to hear some suggestions/improvements if there are any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://w3c.github.io/mediasession