Standardize IN clause generation #7221
Open
+247
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-matthewb
approved these changes
Nov 20, 2025
…LYZE in-clause temp tables immediately after creating/populating/indexing them.
…ed IN clauses to EXISTS clauses to improve performance.
…ge in a finally block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Delegate most IN clause generation to
SqlDialectMove redundant temp-table IN clause generation code into SqlDialect. Move PostgreSQL-specific IN clause code from
BasePostgreSqlDialectintoPostgreSql92Dialect, since it doesn't apply to Redshift.ANALYZEall IN-clause temp tables immediately after creating/populating/indexing them.getAnalyzeCommandForTable()returnsSQLFragmentSwitch assay run skipping to use an inclusion filter. Switch associated IN clauses to EXISTS clauses to improve performance.
Related Pull Requests