Skip to content

CompareType: fix how parseParams parses null values in JSON arrays #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

CompareType: fix how parseParams parses null values in JSON arrays #7198

wants to merge 3 commits into from

Conversation

@labkey-alan
Copy link
Contributor

@labkey-alan labkey-alan commented Nov 10, 2025 •
edited by labkey-nicka
Loading

Rationale

This PR fixes how CompareType handles null values when parsing JSON arrays

Related Pull Requests

Changes

  • CompareType::parseParams - actually allow null values when parsing JSONArray
    • Previous implementation was coercing null values to "null"
    • Necessary for us to properly parse the NotebookReferenceCompareType

Tasks 📍

  • Manual Testing
  • Needs Automation
  • Verify Fix

@labkey-alan labkey-alan self-assigned this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-nicka labkey-nicka labkey-nicka approved these changes

Assignees

@labkey-alan labkey-alan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@labkey-alan @labkey-nicka @labkey-jeckels