Skip to content

Remove BigFloat from conversions and decompose for small DoubleFloats #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

Remove BigFloat from conversions and decompose for small DoubleFloats #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf63b27
Remove BigFloat from conversions and decompose for small DoubleFloats
oscardssmith Oct 20, 2025
6aaa42a
more simplification
oscardssmith Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Double.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,10 @@ Double64(x::Double16) = isfinite(x) ? Double64(two_sum(Float64(HI(x)), Float64(L
Promote a `Double16` to a `Double32` by converting the `hi` and `lo` attributes
of `x` to `Double32`s and adding in extended precision.
"""
Double32(x::Double16) = isfinite(x) ? Double32(BigFloat(x)) : Double32(Float32(x))
Double32(x::Double64) = isfinite(x) ? Double32(BigFloat(x)) : Double32(Float32(x))
Double16(x::Double64) = isfinite(x) ? Double16(BigFloat(x)) : Double16(Float16(x))
Double16(x::Double32) = isfinite(x) ? Double16(BigFloat(x)) : Double16(Float16(x))
Double32(x::Double16) = isfinite(x) ? Double32(two_sum(Float32(HI(x)), Float32(LO(x)))) : Double32(Float32(x))
Double32(x::Double64) = Double32(HI(x))
Double16(x::Double64) = Double16(HI(x))
Double16(x::Double32) = Double16(HI(x))

# cleanup to support other pkgs
DoubleFloat(x::Float64) = Double64(x, 0.0)
Expand Down Expand Up @@ -245,5 +245,5 @@ function Base.decompose(x::Double64)
return decompose(BigFloat(x))
end
function Base.decompose(x::D) where {D<:Union{Double32,Double16}}
return decompose(Double64(x))
return decompose(Float64(x))
end
Loading