chore: Release - dev → rc #1344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo "XDG_RUNTIME_FIR" == "XDG_RUNTIME_DIR'
typo "XDG_RUNTIME_FIR" == "XDG_RUNTIME_DIR'
Previous behavior of `notify_mute` was to only display the icon of speaker when either the speaker, or the mic was muted. This is fixed by correcting the value of `$srce` (which gets modified in the `toggle_mute` function.
This was
linked to
issues
Oct 17, 2025
… display correct microphone mute/unmute icons (#1368) # Pull Request: Fixed a bug in `notify_mute` function in `volumecontrol.sh` script ## Description Fixed a bug in `notify_mute` function in `volumecontrol.sh` script to display correct microphone mute/unmute icons. Previous behavior of `notify_mute` was to only display the icon of speaker when either the speaker, or the mic was muted. This is fixed by correcting the value of `$srce` (which gets modified in the `toggle_mute` function. ## Type of change - [x] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed.
# Pull Request
## Description
Added the following snippet to the Hyprlock configuration to hide the
cursor on the lock screen:
```css
general {
hide_cursor = true
}
```
The cursor was previously visible during lockscreen, which felt a little
unintuitive. This change hides it.
## Type of change
Please put an `x` in the boxes that apply:
- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [X] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that would cause existing
functionality to not work as expected)
- [ ] **Documentation update** (non-breaking change; modified files are
limited to the documentations)
- [ ] **Technical debt** (a code change that does not fix a bug or add a
feature but makes something clearer for devs)
- [ ] **Other** (provide details below)
## Checklist
- [X] I have read the
[CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md)
document.
- [X] My code follows the code style of this project.
- [X] My commit message follows the [commit
guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added a changelog entry.
- [ ] I have added necessary comments/documentation to my code.
- [ ] I have added tests to cover my changes.
- [X] I have tested my code locally and it works as expected.
- [X] All new and existing tests passed.
## Screenshots
I am trying to capture the cursor in satty but I am a little stuck
there. I will update the PR if it works out.
## Additional context
An issue was reported in hyprlock where the cursor wouldn't be visible
after logging back in: hyprwm/hyprlock#494.
However, I was unable to reproduce that behavior locally, and these
changes appear to work as intended.
# Pull Request ## Description Please read these instructions and remove unnecessary text. - Try to include a summary of the changes and which issue is fixed. - Also include relevant motivation and context (if applicable). - Make sure to make PR against dev and not the master - List any dependencies that are required for this change. (e.g., packages or other PRs) - Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue) - Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable) ## Type of change Please put an `x` in the boxes that apply: - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [x] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [ ] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Screenshots (if appropriate) ## Additional context Add any other context about the problem here.
…flags TODO try to use it for most of the hyde-shell stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated PR to promote changes from
devtorc.Please review and test before merging.
See TESTING.md for complete testing instructions.
According to our release policy, this PR is expected to be merged during: Freeze Week (see release policy)
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the project.
notify_mutefunction involumecontrol.shscript to display correct microphone mute/unmute icons (Fixed a bug innotify_mutefunction involumecontrol.shscript to display correct microphone mute/unmute icons #1368) (f28c88c) by KhingPlease review the changes carefully before merging.