krita: add linux appimage support #222068
Open
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
github-actions
bot
added
the
stale
SMillerDev
force-pushed
the
feat/krita/appimage
branch
from
a759801 to
d1829ac
Compare
github-actions
bot
removed
the
stale
SMillerDev
force-pushed
the
feat/krita/appimage
branch
from
d1829ac to
bdcb6e8
Compare
SMillerDev
force-pushed
the
feat/krita/appimage
branch
from
bdcb6e8 to
776bf6d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds Linux AppImage support to the Krita cask, enabling cross-platform installation through Homebrew. The changes introduce conditional logic to handle different download formats and installation methods for macOS and Linux platforms.
- Implements platform-specific download URLs using conditional suffixes
- Updates SHA256 checksums to support multiple architectures including Linux x86_64
- Adds Linux-specific installation logic with AppImage support
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+4
to
+5
| sha256 arm: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", | ||
| x86_64: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", |
There was a problem hiding this comment.
The ARM and x86_64 macOS checksums are identical, which is unlikely to be correct since these would be different binaries for different architectures.
Suggested change
| sha256 arm: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", | |
| x86_64: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", | |
| sha256 arm: "REPLACE_WITH_ACTUAL_ARM_SHA256", | |
| x86_64: "REPLACE_WITH_ACTUAL_X86_64_SHA256", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.Accompanies Homebrew/brew#20334 as an example