[GSoC 2025] Final Report - TMVA - SOFIE Project - PrasannaKasar #1756
+189
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for earnest-hotteok-b1e1bf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
hi @maszyman |
Contributor
|
Could you please review? |
maszyman
approved these changes
Oct 31, 2025
maszyman
approved these changes
Oct 31, 2025
Contributor
maszyman
left a comment
maszyman
left a comment
There was a problem hiding this comment.
LGTM, but I would like mentors to have a look
Author
|
Yes sure |
Author
|
Should I tag them here? @maszyman |
Contributor
|
Already did in #1756 (comment) ;-) |
Author
|
Okay |
Contributor
|
LGTM! |
sanjibansg
suggested changes
Oct 31, 2025
Contributor
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
Looks good overall, thanks for the report. Some suggestions:
Author
|
Hi @sanjibansg I implemented the suggestions. Can you please have a look at them once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: TMVA SOFIE - Enhancing Keras Parser and JAX/FLAX Integration