- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 775
Implement player entity collision pushing. #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
        
          
                core/src/main/java/org/geysermc/geyser/entity/type/living/animal/horse/AbstractHorseEntity.java
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Co-authored-by: chris <github@onechris.mozmail.com>
        
          
                api/src/main/java/org/geysermc/geyser/api/entity/type/player/GeyserPlayerEntity.java
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Co-authored-by: chris <github@onechris.mozmail.com>
| In my testing this PR now works pretty well, so it's now ready to be merge. Ofc, feel free to test it as much as you like :) to see if there still any problems left with it :P | 
      
        
              This comment was marked as off-topic.
        
        
      
    
  This comment was marked as off-topic.
        
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...a/org/geysermc/geyser/translator/protocol/bedrock/entity/player/input/BedrockMovePlayer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …rock/entity/player/input/BedrockMovePlayer.java Co-authored-by: chris <github@onechris.mozmail.com>
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| Is there Minecraft Teams Support? | 
| 
 I think this is the wrong place for that. | 
| Pretty sure this is for collisions not about plugins. | 
| Yes, collision rules set in scoreboard teams will be accounted for in this PR | 
| 
 The point of Minecraft teams support is so some plugins that disable collisions is compatible with this collisions PR | 
| 
 I second that this is important. I utilise TAB's API to disable collisions within the spawn area of my server (so players can't push others outside it), but enable them everywhere else. | 
| As mentioned before - this PR accounts for teams and their collision rules already; so that will work fine | 
This is another attempt of implementing player entity collision push since #1357 PR went stale. This should works somewhat better than the old PR but still have issues, it's not perfect.
For ex: in some rare case player might have weird motion when jumping which idk if it's fixable(should now be fix), feel free to player around with it tho :). Resolve #3702.