Anvil updater refactor and other small refactors #5595
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclipseisoffline
force-pushed
the
anvil-xp-fix
branch
from
96ab95d to
b6f5c39
Compare
eclipseisoffline
added a commit
to eclipseisoffline/Geyser
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies some refactors to the
AnvilInventoryUpdaterclass and makes some other small refactors around the code, most notably some utility methods inGeyserItemStack, and of course, some tag/registry cache refactors. Still in the works, most notably I noticed some bugs with repair cost not being calculated correctly when renaming items and repair cost being set incorrect when switching items around in the anvil menu.This PR should fix #5545 and might fix #5584.