feat(save_and_load): add import/export methods #249

MaxNumerique · 2025-10-28T08:10:22Z

…persistence

create project manager plugin for import/export operations update tests for new functionality and async loading

…persistence create project manager plugin for import/export operations update tests for new functionality and async loading

…ns/OpenGeodeWeb-Front into feat/save_and_load

…b-Front into feat/save_and_load

BotellaA · 2025-10-28T09:44:56Z

plugins/project_manager.js

Quel est l'objectif de ce plug-in, c'est pas déjà le rôle de l'app store?

Pour moi l'app_store ne fait que de la gestion d'état sans créer de fichier ni réseau. Il permet de créer un snapshot avec le save() sous forme d'objet.
Le plugin utilise les méthode de l'appStore pour transformer le snapshot en JSON et créé un Blob, enfin lance un téléchargement pour le save.

Pour moi, le plugin utilise app_store comme moteur de snapshot et ne réimplémente pas le save & load

Je crois que je comprends, dans l'idée il faudrait :
exporter : compresser l'état de Project_folder_path et lui passer aussi le snapshot pour restaurer le style, etc. et ziper le tout
importer : recoit le zip, remplace le project_folder actuel et utilise aussi le snapshot qui sera utilisé par les stores dans le Front

Un plug-in de pinia, c'est globalement l'idée d'ajouter une fonctionalité à tous les stores ou certains. Là, ce que tu veux ajouter ces pas vraiment en line avec pinia et les stores mais plutôt une action spécifique de l'app store. Qui en effet est un peu plus complexe que juste l'app store, ta question est pertinente.

Peut-être qu'il faut mettre la logique de ton plug-in dans un composable qui utiliserait l'app store et le geode store ? @JulienChampagnol qu'en penses tu ?

Je vais voir pour porter project_manager en tant que composable et non en tant que plugin Pinia et en même temps utiliser le store geode.js

…ns/OpenGeodeWeb-Front into feat/save_and_load

BotellaA · 2025-10-30T18:10:15Z

composables/project_manager.js

@JulienChampagnol que penses tu de cette proposition ?

stores/app.js

stores/treeview.js

composables/project_manager.js

tests/unit/plugins/ProjectLoad.nuxt.test.js

stores/data_base.js

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/data_style.js

Line 54 in 7d392c0

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/data_style.js

Line 63 in 7d392c0

async function applyAllStylesFromState() {

_{reported by reviewdog 🐶}
Unexpected await inside a loop.

OpenGeodeWeb-Front/stores/data_style.js

Line 71 in 7d392c0

await meshStyleStore.applyMeshStyle(id)

_{reported by reviewdog 🐶}
Unexpected await inside a loop.

OpenGeodeWeb-Front/stores/data_style.js

Line 73 in 7d392c0

await modelStyleStore.applyModelStyle(id)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/data_style.js

Line 20 in 7d392c0

console.warn("[DataStyle] setVisibility skipped: unknown id", id)

_{reported by reviewdog 🐶}
Unexpected use of continue statement.

OpenGeodeWeb-Front/stores/data_style.js

Line 69 in 7d392c0

if (!style || !objectType) continue

_{reported by reviewdog 🐶}
Use Object destructuring.

OpenGeodeWeb-Front/stores/data_style.js

Line 23 in 7d392c0

const object_type = meta.object_type

_{reported by reviewdog 🐶}
Async function has no 'await' expression.

OpenGeodeWeb-Front/stores/data_style.js

Line 54 in 7d392c0

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/data_style.js

Line 54 in 7d392c0

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/data_style.js

Line 63 in 7d392c0

async function applyAllStylesFromState() {

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_style.js

Line 55 in 7d392c0

const stylesSnapshot = snapshot?.styles || {}

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_style.js

Line 67 in 7d392c0

const objectType = meta?.object_type

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 236 in 7d392c0

if (cam.focal_point) camera.setFocalPoint(cam.focal_point)

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 237 in 7d392c0

if (cam.view_up) camera.setViewUp(cam.view_up)

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 238 in 7d392c0

if (cam.position) camera.setPosition(cam.position)

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 239 in 7d392c0

if (cam.view_angle != null) camera.setViewAngle(cam.view_angle)

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 240 in 7d392c0

if (cam.clipping_range) camera.setClippingRange(cam.clipping_range)

_{reported by reviewdog 🐶}
Expected !== and instead saw !=

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 227 in 7d392c0

if (z_scale != null) {

_{reported by reviewdog 🐶}
Expected !== and instead saw !=

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 239 in 7d392c0

if (cam.view_angle != null) camera.setViewAngle(cam.view_angle)

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 201 in 7d392c0

function clear() {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 209 in 7d392c0

function exportStores() {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 225 in 7d392c0

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Require for-in loops to include an if statement

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 249 in 7d392c0

for (const key in cam) {

_{reported by reviewdog 🐶}
Do not use null comparisons without type-checking operators.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 227 in 7d392c0

if (z_scale != null) {

_{reported by reviewdog 🐶}
Do not use null comparisons without type-checking operators.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 239 in 7d392c0

if (cam.view_angle != null) camera.setViewAngle(cam.view_angle)

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 225 in 7d392c0

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 210 in 7d392c0

const renderer = genericRenderWindow.value?.getRenderer?.()

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 211 in 7d392c0

const camera = renderer?.getActiveCamera?.()

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 226 in 7d392c0

const z_scale = snapshot?.zScale

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 231 in 7d392c0

const cam = snapshot?.camera_options

_{reported by reviewdog 🐶}
Do not use Array#forEach

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 204 in 7d392c0

actors.forEach((actor) => renderer.removeActor(actor))

_{reported by reviewdog 🐶}
Do not use Array#forEach

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 206 in 7d392c0

Object.keys(db).forEach((id) => delete db[id])

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 227 in 7d392c0

if (z_scale != null) {

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 239 in 7d392c0

if (cam.view_angle != null) camera.setViewAngle(cam.view_angle)

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 214 in 7d392c0

focal_point: Array.from(camera.getFocalPoint()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 215 in 7d392c0

view_up: Array.from(camera.getViewUp()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 216 in 7d392c0

position: Array.from(camera.getPosition()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 218 in 7d392c0

clipping_range: Array.from(camera.getClippingRange()),

github-actions · 2025-11-07T11:16:37Z

utils/file_import_workflow.js

 }

-export { importFile, importWorkflow }
+async function importWorkflowFromSnapshot(items) {


_{reported by reviewdog 🐶}
Expected a function expression.

github-actions · 2025-11-07T11:16:38Z

utils/file_import_workflow.js

 }

-export { importFile, importWorkflow }
+async function importWorkflowFromSnapshot(items) {


_{reported by reviewdog 🐶}
async is not allowed

github-actions · 2025-11-07T11:16:39Z

tests/unit/composables/ProjectManager.nuxt.test.js

+  viewer_call: vi.fn(),
+}))
+
+beforeEach(async () => {


_{reported by reviewdog 🐶}
async is not allowed

github-actions · 2025-11-07T11:16:39Z

tests/unit/composables/ProjectManager.nuxt.test.js

+  },
+}))
+vi.mock("@/composables/api_fetch.js", () => ({
+  api_fetch: vi.fn(async (_req, options = {}) => {


_{reported by reviewdog 🐶}
async is not allowed

github-actions · 2025-11-07T11:16:39Z

tests/unit/composables/ProjectManager.nuxt.test.js

+}))
+vi.stubGlobal(
+  "$fetch",
+  vi.fn(async () => ({ snapshot: {} })),


_{reported by reviewdog 🐶}
async is not allowed

github-actions · 2025-11-07T11:16:39Z

tests/unit/composables/ProjectManager.nuxt.test.js

@@ -0,0 +1,129 @@
+import { beforeEach, describe, expect, test, vi } from "vitest"


_{reported by reviewdog 🐶}
Filename should be in snake case

github-actions · 2025-11-07T11:16:39Z

tests/unit/composables/ProjectManager.nuxt.test.js

+    const response = {
+      _data: new Blob(["zipcontent"], { type: "application/zip" }),
+      headers: {
+        get: (k) => (k === "new-file-name" ? "project_123.zip" : null),


_{reported by reviewdog 🐶}
Do not use null literals

github-actions · 2025-11-07T11:16:39Z

stores/app.js

-        snapshot[storeId] = store.save()
-        savedCount++
+        snapshot[storeId] = store.exportStores()
+        exportCount++


_{reported by reviewdog 🐶}
Unary operator '++' used.

github-actions · 2025-11-07T11:16:40Z

stores/app.js

-        store.load(snapshot[storeId])
-        loadedCount++
+        await store.importStores(snapshot[storeId])
+        importedCount++


_{reported by reviewdog 🐶}
Unary operator '++' used.

github-actions · 2025-11-07T11:16:40Z

stores/app.js

  }

-  function load(snapshot) {
+  async function importStores(snapshot) {


_{reported by reviewdog 🐶}
async is not allowed

…ns/OpenGeodeWeb-Front into feat/save_and_load

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/data_style.js

Line 20 in a1725f8

console.warn("[DataStyle] setVisibility skipped: unknown id", id)

_{reported by reviewdog 🐶}
Unexpected use of continue statement.

OpenGeodeWeb-Front/stores/data_style.js

Line 69 in a1725f8

if (!style || !objectType) continue

_{reported by reviewdog 🐶}
Use Object destructuring.

OpenGeodeWeb-Front/stores/data_style.js

Line 23 in a1725f8

const object_type = meta.object_type

_{reported by reviewdog 🐶}
Async function has no 'await' expression.

OpenGeodeWeb-Front/stores/data_style.js

Line 54 in a1725f8

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/data_style.js

Line 54 in a1725f8

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/data_style.js

Line 63 in a1725f8

async function applyAllStylesFromState() {

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_style.js

Line 55 in a1725f8

const stylesSnapshot = snapshot?.styles || {}

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_style.js

Line 67 in a1725f8

const objectType = meta?.object_type

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 23 in a1725f8

if (status.value !== Status.NOT_CREATED) return

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 39 in a1725f8

if (is_moving.value) return

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 93 in a1725f8

if (!schema) return

_{reported by reviewdog 🐶}
Expected === and instead saw ==

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 153 in a1725f8

if (event.button == 0) {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 22 in a1725f8

async function initHybridViewer() {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 50 in a1725f8

async function addItem(id) {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 75 in a1725f8

async function setVisibility(id, visibility) {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 80 in a1725f8

async function setZScaling(z_scale) {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 102 in a1725f8

function syncRemoteCamera() {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 132 in a1725f8

function remoteRender() {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 138 in a1725f8

function setContainer(container) {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 181 in a1725f8

async function resize(width, height) {

_{reported by reviewdog 🐶}
Require for-in loops to include an if statement

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 124 in a1725f8

for (const key in params.camera_options) {

_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 38 in a1725f8

viewStream.onImageReady((e) => {

_{reported by reviewdog 🐶}
Variable 'viewStream' should be initialized on declaration.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 19 in a1725f8

let viewStream

_{reported by reviewdog 🐶}
The function has too many lines (205). Maximum allowed is 50.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 10 in a1725f8

export const useHybridViewerStore = defineStore("hybridViewer", () => {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 55 in a1725f8

console.log("hybridViewerStore.addItem", { value })

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 103 in a1725f8

console.log("syncRemoteCamera")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 147 in a1725f8

console.log("setContainer", container.value.$el)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 152 in a1725f8

console.log("onPressed")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 164 in a1725f8

console.log("onReleased")

_{reported by reviewdog 🐶}
1.0

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 18 in a1725f8

const zScale = ref(1.0)

_{reported by reviewdog 🐶}
180

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 26 in a1725f8

background: [180 / 255, 180 / 255, 180 / 255],

_{reported by reviewdog 🐶}
255

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 26 in a1725f8

background: [180 / 255, 180 / 255, 180 / 255],

_{reported by reviewdog 🐶}
180

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 26 in a1725f8

background: [180 / 255, 180 / 255, 180 / 255],

_{reported by reviewdog 🐶}
255

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 26 in a1725f8

background: [180 / 255, 180 / 255, 180 / 255],

_{reported by reviewdog 🐶}
180

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 26 in a1725f8

background: [180 / 255, 180 / 255, 180 / 255],

_{reported by reviewdog 🐶}
255

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 26 in a1725f8

background: [180 / 255, 180 / 255, 180 / 255],

_{reported by reviewdog 🐶}
0

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 61 in a1725f8

const polydata = reader.getOutputData(0)

_{reported by reviewdog 🐶}
20

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 65 in a1725f8

actor.getProperty().setColor(20 / 255, 20 / 255, 20 / 255)

_{reported by reviewdog 🐶}
255

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 65 in a1725f8

actor.getProperty().setColor(20 / 255, 20 / 255, 20 / 255)

_{reported by reviewdog 🐶}
20

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 65 in a1725f8

actor.getProperty().setColor(20 / 255, 20 / 255, 20 / 255)

_{reported by reviewdog 🐶}
255

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 65 in a1725f8

actor.getProperty().setColor(20 / 255, 20 / 255, 20 / 255)

_{reported by reviewdog 🐶}
20

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 65 in a1725f8

actor.getProperty().setColor(20 / 255, 20 / 255, 20 / 255)

_{reported by reviewdog 🐶}
255

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 65 in a1725f8

actor.getProperty().setColor(20 / 255, 20 / 255, 20 / 255)

_{reported by reviewdog 🐶}
0

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 87 in a1725f8

actor.setScale(scale[0], scale[1], z_scale)

_{reported by reviewdog 🐶}
1

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 87 in a1725f8

actor.setScale(scale[0], scale[1], z_scale)

_{reported by reviewdog 🐶}
0

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 153 in a1725f8

if (event.button == 0) {

_{reported by reviewdog 🐶}
600

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 177 in a1725f8

}, 600)

_{reported by reviewdog 🐶}
Async function has no 'await' expression.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 75 in a1725f8

async function setVisibility(id, visibility) {

_{reported by reviewdog 🐶}
Imports should be sorted alphabetically.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 4 in a1725f8

import vtkMapper from "@kitware/vtk.js/Rendering/Core/Mapper"

_{reported by reviewdog 🐶}
Imports should be sorted alphabetically.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 5 in a1725f8

import vtkActor from "@kitware/vtk.js/Rendering/Core/Actor"

_{reported by reviewdog 🐶}
Imports should be sorted alphabetically.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 8 in a1725f8

import Status from "@ogw_f/utils/status.js"

_{reported by reviewdog 🐶}
Named exports are not allowed.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 10 in a1725f8

export const useHybridViewerStore = defineStore("hybridViewer", () => {

_{reported by reviewdog 🐶}
Imported module should be assigned

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 1 in a1725f8

import "@kitware/vtk.js/Rendering/Profiles/Geometry"

_{reported by reviewdog 🐶}
Prefer default export on a file with single export.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 10 in a1725f8

export const useHybridViewerStore = defineStore("hybridViewer", () => {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 22 in a1725f8

async function initHybridViewer() {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 50 in a1725f8

async function addItem(id) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 75 in a1725f8

async function setVisibility(id, visibility) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 80 in a1725f8

async function setZScaling(z_scale) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 181 in a1725f8

async function resize(width, height) {

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 92 in a1725f8

const schema = viewer_schemas?.opengeodeweb_viewer?.viewer?.set_z_scaling

_{reported by reviewdog 🐶}
Do not use Array#forEach

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 84 in a1725f8

actors.forEach((actor) => {

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 20 in a1725f8

let gridActor = null

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 169 in a1725f8

let wheelEventEndTimeout = null

_{reported by reviewdog 🐶}
Don't use a zero fraction in the number.

OpenGeodeWeb-Front/internal_stores/mesh/index.js

Line 18 in a1725f8

const zScale = ref(1.0)

github-actions · 2025-11-07T11:42:31Z

composables/viewer_call.js

  return new Promise((resolve, reject) => {
-    if (!client) {
-      reject()
+    if (!client?.getConnection) {


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

…b-Front into feat/save_and_load

…ns/OpenGeodeWeb-Front into feat/save_and_load

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 125 in 933cb71

const n = a.map((x) => Number(x))

_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 126 in 933cb71

return n.every((x) => Number.isFinite(x)) ? n : null

_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 127 in 933cb71

} catch (_) {

_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 218 in 933cb71

w: container.value?.$el?.offsetWidth,

_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 219 in 933cb71

h: container.value?.$el?.offsetHeight,

_{reported by reviewdog 🐶}
The async function importStores has too many lines (76). Maximum allowed is 50.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 334 in 933cb71

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 24 in 933cb71

console.log("[hybrid_viewer] initHybridViewer: status", status.value)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 38 in 933cb71

console.log("[hybrid_viewer] ws_connect done")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 40 in 933cb71

console.log("[hybrid_viewer] viewStream created (-1)")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 46 in 933cb71

console.log("[hybrid_viewer] onImageReady", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 71 in 933cb71

console.log(

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 83 in 933cb71

console.log(

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 89 in 933cb71

console.log("[hybrid_viewer] addItem render done")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 133 in 933cb71

console.log("[hybrid_viewer] syncRemoteCamera")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 145 in 933cb71

console.log("[hybrid_viewer] camera raw", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 176 in 933cb71

console.log("[hybrid_viewer] camera normalized", normalized)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 180 in 933cb71

console.warn(

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 188 in 933cb71

console.log("[hybrid_viewer] viewer.update_camera request", params)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 197 in 933cb71

console.log(

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 208 in 933cb71

console.log("[hybrid_viewer] viewer.render request")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 215 in 933cb71

console.log("[hybrid_viewer] setContainer attach", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 227 in 933cb71

console.log("[hybrid_viewer] bgImage style before", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 240 in 933cb71

console.log("[hybrid_viewer] onPressed", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 248 in 933cb71

console.log("[hybrid_viewer] onPressed applied", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 255 in 933cb71

console.log("[hybrid_viewer] onReleased", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 262 in 933cb71

console.log("[hybrid_viewer] onReleased -> syncRemoteCamera")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 271 in 933cb71

console.log("[hybrid_viewer] wheel", { bg_opacity: imageStyle.opacity })

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 275 in 933cb71

console.log("[hybrid_viewer] wheel end -> syncRemoteCamera")

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 288 in 933cb71

console.log("[hybrid_viewer] resize", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 304 in 933cb71

console.log("[hybrid_viewer] resize applied", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 342 in 933cb71

console.log("[hybrid_viewer] importStores snapshot camera", cam)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 354 in 933cb71

console.log("[hybrid_viewer] importStores normalized camera", {

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 364 in 933cb71

console.warn(

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 379 in 933cb71

console.log("[hybrid_viewer] importStores -> viewer.update_camera", {

_{reported by reviewdog 🐶}
Do not use null comparisons without type-checking operators.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 336 in 933cb71

if (z_scale != null) {

_{reported by reviewdog 🐶}
3

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 163 in 933cb71

const fp = toNumArray(raw.focal_point, 3)

_{reported by reviewdog 🐶}
3

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 164 in 933cb71

const vu = toNumArray(raw.view_up, 3)

_{reported by reviewdog 🐶}
3

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 165 in 933cb71

const pos = toNumArray(raw.position, 3)

_{reported by reviewdog 🐶}
2

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 166 in 933cb71

const cr = toNumArray(raw.clipping_range, 2)

_{reported by reviewdog 🐶}
3

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 346 in 933cb71

const fp = toNumArray(cam.focal_point, 3)

_{reported by reviewdog 🐶}
3

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 347 in 933cb71

const vu = toNumArray(cam.view_up, 3)

_{reported by reviewdog 🐶}
3

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 348 in 933cb71

const pos = toNumArray(cam.position, 3)

_{reported by reviewdog 🐶}
2

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 349 in 933cb71

const cr = toNumArray(cam.clipping_range, 2)

_{reported by reviewdog 🐶}
Catch parameter '_' is caught but never used.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 127 in 933cb71

} catch (_) {

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 334 in 933cb71

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 49 in 933cb71

image: typeof e?.image,

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 73 in 933cb71

polydata?.getBounds?.(),

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 216 in 933cb71

el: container.value?.$el,

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 218 in 933cb71

w: container.value?.$el?.offsetWidth,

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 219 in 933cb71

h: container.value?.$el?.offsetHeight,

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 319 in 933cb71

const renderer = genericRenderWindow.value?.getRenderer?.()

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 320 in 933cb71

const camera = renderer?.getActiveCamera?.()

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 335 in 933cb71

const z_scale = snapshot?.zScale

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 340 in 933cb71

const cam = snapshot?.camera_options

_{reported by reviewdog 🐶}
Function toNumArray does not capture any variables from its parent scope

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 121 in 933cb71

function toNumArray(arrLike, expectedLen) {

_{reported by reviewdog 🐶}
Do not use Array#forEach

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 313 in 933cb71

actors.forEach((actor) => renderer.removeActor(actor))

_{reported by reviewdog 🐶}
Do not use Array#forEach

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 315 in 933cb71

Object.keys(db).forEach((id) => delete db[id])

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 124 in 933cb71

if (a.length !== expectedLen) return null

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 126 in 933cb71

return n.every((x) => Number.isFinite(x)) ? n : null

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 128 in 933cb71

return null

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 336 in 933cb71

if (z_scale != null) {

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 123 in 933cb71

const a = Array.from(arrLike ?? [])

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 323 in 933cb71

focal_point: Array.from(camera.getFocalPoint()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 324 in 933cb71

view_up: Array.from(camera.getViewUp()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 325 in 933cb71

position: Array.from(camera.getPosition()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 327 in 933cb71

clipping_range: Array.from(camera.getClippingRange()),

_{reported by reviewdog 🐶}
The function is equivalent to Number. Call Number directly.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 125 in 933cb71

const n = a.map((x) => Number(x))

_{reported by reviewdog 🐶}
Prefer omitting the catch binding parameter if it is unused

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 127 in 933cb71

} catch (_) {

github-actions · 2025-11-07T15:04:56Z

utils/file_import_workflow.js

 }

-export { importFile, importWorkflow }
+async function importWorkflowFromSnapshot(items) {


_{reported by reviewdog 🐶}
The async function importWorkflowFromSnapshot has too many lines (69). Maximum allowed is 50.

github-actions · 2025-11-07T15:04:56Z

utils/file_import_workflow.js

+      displayed_name: item.displayed_name,
+    })
+
+    await dataBaseStore.registerObject(item.id)


_{reported by reviewdog 🐶}
Unexpected await inside a loop.

github-actions · 2025-11-07T15:04:56Z

utils/file_import_workflow.js

+    await dataBaseStore.registerObject(item.id)
+    console.log("[importWorkflowFromSnapshot] registerObject ok", item.id)
+
+    await dataBaseStore.addItem(item.id, {


_{reported by reviewdog 🐶}
Unexpected await inside a loop.

github-actions · 2025-11-07T15:04:57Z

utils/file_import_workflow.js

+    })
+    console.log("[importWorkflowFromSnapshot] addItem ok", item.id)
+
+    await treeviewStore.addItem(


_{reported by reviewdog 🐶}
Unexpected await inside a loop.

github-actions · 2025-11-07T15:04:57Z

utils/file_import_workflow.js

+    )
+    console.log("[importWorkflowFromSnapshot] treeview.addItem ok", item.id)
+
+    await hybridViewerStore.addItem(item.id)


_{reported by reviewdog 🐶}
Unexpected await inside a loop.

github-actions · 2025-11-07T15:04:58Z

utils/file_import_workflow.js

+    }
+
+    await dataStyleStore.applyDefaultStyle(item.id)
+    console.log(


_{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2025-11-07T15:04:58Z

utils/file_import_workflow.js

+    ids.push(item.id)
+  }
+  hybridViewerStore.remoteRender()
+  console.log("[importWorkflowFromSnapshot] remoteRender called")


_{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2025-11-07T15:04:58Z

utils/file_import_workflow.js

+  }
+  hybridViewerStore.remoteRender()
+  console.log("[importWorkflowFromSnapshot] remoteRender called")
+  console.log("[importWorkflowFromSnapshot] done", { ids })


_{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2025-11-07T15:04:58Z

utils/file_import_workflow.js

+  return ids
+}
+
+export { importFile, importWorkflow, importWorkflowFromSnapshot }


_{reported by reviewdog 🐶}
Named exports are not allowed.

github-actions · 2025-11-07T15:04:58Z

utils/file_import_workflow.js


-export { importFile, importWorkflow }
+async function importWorkflowFromSnapshot(items) {
+  console.log("[importWorkflowFromSnapshot] start", { count: items?.length })


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

…ns/OpenGeodeWeb-Front into feat/save_and_load

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 240 in 28abd57

const renderer = genericRenderWindow.value?.getRenderer?.()

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 241 in 28abd57

const camera = renderer?.getActiveCamera?.()

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 256 in 28abd57

const z_scale = snapshot?.zScale

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 261 in 28abd57

const cam = snapshot?.camera_options

_{reported by reviewdog 🐶}
Function sanitizeCameraOptions does not capture any variables from its parent scope

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 23 in 28abd57

function sanitizeCameraOptions(opts) {

_{reported by reviewdog 🐶}
Function toNums does not capture any variables from its parent scope

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 23 in 28abd57

function sanitizeCameraOptions(opts) {

_{reported by reviewdog 🐶}
Function logCameraOptions does not capture any variables from its parent scope

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 38 in 28abd57

function logCameraOptions(label, opts) {

_{reported by reviewdog 🐶}
Function types does not capture any variables from its parent scope

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 38 in 28abd57

function logCameraOptions(label, opts) {

_{reported by reviewdog 🐶}
Do not use Array#forEach

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 234 in 28abd57

actors.forEach((actor) => renderer.removeActor(actor))

_{reported by reviewdog 🐶}
Do not use Array#forEach

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 236 in 28abd57

Object.keys(db).forEach((id) => delete db[id])

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 24 in 28abd57

if (!opts) return null

_{reported by reviewdog 🐶}
Do not use null literals

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 257 in 28abd57

if (z_scale != null) {

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 26 in 28abd57

Array.from(arr || [])

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 39 in 28abd57

const types = (arr) => Array.from(arr || []).map((v) => typeof v)

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 244 in 28abd57

focal_point: Array.from(camera.getFocalPoint()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 245 in 28abd57

view_up: Array.from(camera.getViewUp()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 246 in 28abd57

position: Array.from(camera.getPosition()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 248 in 28abd57

clipping_range: Array.from(camera.getClippingRange()),

_{reported by reviewdog 🐶}
The function is equivalent to Number. Call Number directly.

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 28 in 28abd57

.map((n) => Number(n))

…ns/OpenGeodeWeb-Front into feat/save_and_load

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 213 in e6d2c43

view_up: Array.from(camera.getViewUp()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 214 in e6d2c43

position: Array.from(camera.getPosition()),

_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

OpenGeodeWeb-Front/stores/hybrid_viewer.js

Line 216 in e6d2c43

clipping_range: Array.from(camera.getClippingRange()),

_{reported by reviewdog 🐶}
Expected { after 'if' condition.

OpenGeodeWeb-Front/stores/data_base.js

Line 139 in e6d2c43

if (!item) continue

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/data_base.js

Line 136 in e6d2c43

function exportStores() {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/data_base.js

Line 154 in e6d2c43

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Expected a function expression.

OpenGeodeWeb-Front/stores/data_base.js

Line 167 in e6d2c43

function clear() {

_{reported by reviewdog 🐶}
Unexpected await inside a loop.

OpenGeodeWeb-Front/stores/data_base.js

Line 162 in e6d2c43

await registerObject(id)

_{reported by reviewdog 🐶}
Unexpected await inside a loop.

OpenGeodeWeb-Front/stores/data_base.js

Line 163 in e6d2c43

await addItem(id, item)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/data_base.js

Line 157 in e6d2c43

console.log(

_{reported by reviewdog 🐶}
Unexpected use of continue statement.

OpenGeodeWeb-Front/stores/data_base.js

Line 139 in e6d2c43

if (!item) continue

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/data_base.js

Line 154 in e6d2c43

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_base.js

Line 147 in e6d2c43

binary_light_viewable: item?.vtk_js?.binary_light_viewable,

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_base.js

Line 159 in e6d2c43

Object.keys(snapshot?.db || {}),

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_base.js

Line 161 in e6d2c43

for (const [id, item] of Object.entries(snapshot?.db || {})) {

github-actions · 2025-11-07T22:14:06Z

composables/project_manager.js

+import viewer_schemas from "@geode/opengeodeweb-viewer/opengeodeweb_viewer_schemas.json"
+import fileDownload from "js-file-download"
+
+export function useProjectManager() {


_{reported by reviewdog 🐶}
The function useProjectManager has too many lines (97). Maximum allowed is 50.

github-actions · 2025-11-07T22:14:06Z

composables/project_manager.js

+    }
+  }
+
+  async function importProjectFile(file) {


_{reported by reviewdog 🐶}
The async function importProjectFile has too many lines (66). Maximum allowed is 50.

github-actions · 2025-11-07T22:14:06Z

composables/project_manager.js

+  return { exportProject, importProjectFile }
+}
+
+export default useProjectManager


_{reported by reviewdog 🐶}
Prefer named exports

github-actions · 2025-11-07T22:14:06Z

composables/project_manager.js

+
+      const schemaImport = back_schemas.opengeodeweb_back.import_project
+      const form = new FormData()
+      form.append("file", file, file?.name)


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-07T22:14:06Z

composables/project_manager.js

+        method: "POST",
+        body: form,
+      })
+      const snapshot = result?.snapshot ?? {}


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-07T22:14:08Z

stores/hybrid_viewer.js

+  }
+
+  async function importStores(snapshot) {
+    const z_scale = snapshot?.zScale


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-07T22:14:08Z

stores/hybrid_viewer.js

+  function clear() {
+    const renderer = genericRenderWindow.value.getRenderer()
+    const actors = renderer.getActors()
+    actors.forEach((actor) => renderer.removeActor(actor))


_{reported by reviewdog 🐶}
Do not use Array#forEach

github-actions · 2025-11-07T22:14:08Z

stores/hybrid_viewer.js

+    const actors = renderer.getActors()
+    actors.forEach((actor) => renderer.removeActor(actor))
+    genericRenderWindow.value.getRenderWindow().render()
+    Object.keys(db).forEach((id) => delete db[id])


_{reported by reviewdog 🐶}
Do not use Array#forEach

github-actions · 2025-11-07T22:14:08Z

stores/hybrid_viewer.js

+
+  async function importStores(snapshot) {
+    const z_scale = snapshot?.zScale
+    if (z_scale != null) {


_{reported by reviewdog 🐶}
Do not use null literals

github-actions · 2025-11-07T22:14:09Z

stores/hybrid_viewer.js

+    const camera = renderer?.getActiveCamera?.()
+    const cameraSnapshot = camera
+      ? {
+          focal_point: Array.from(camera.getFocalPoint()),


_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

_{reported by reviewdog 🐶}
Unexpected await inside a loop.

OpenGeodeWeb-Front/stores/data_base.js

Line 162 in 17607da

await registerObject(id)

_{reported by reviewdog 🐶}
Unexpected await inside a loop.

OpenGeodeWeb-Front/stores/data_base.js

Line 163 in 17607da

await addItem(id, item)

_{reported by reviewdog 🐶}
Unexpected console statement.

OpenGeodeWeb-Front/stores/data_base.js

Line 157 in 17607da

console.log(

_{reported by reviewdog 🐶}
Unexpected use of continue statement.

OpenGeodeWeb-Front/stores/data_base.js

Line 139 in 17607da

if (!item) continue

_{reported by reviewdog 🐶}
async is not allowed

OpenGeodeWeb-Front/stores/data_base.js

Line 154 in 17607da

async function importStores(snapshot) {

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_base.js

Line 147 in 17607da

binary_light_viewable: item?.vtk_js?.binary_light_viewable,

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_base.js

Line 159 in 17607da

Object.keys(snapshot?.db || {}),

_{reported by reviewdog 🐶}
Optional chaining is not allowed.

OpenGeodeWeb-Front/stores/data_base.js

Line 161 in 17607da

for (const [id, item] of Object.entries(snapshot?.db || {})) {

github-actions · 2025-11-08T09:18:15Z

utils/default_styles.js

 const lines_defaultColor = { r: 20, g: 20, b: 20 }
 const surfaces_defaultVisibility = true
-const surfaces_defaultColor = { r: 20, g: 20, b: 20 }
+const surfaces_defaultColor = { r: 255, g: 255, b: 255 }


_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

github-actions · 2025-11-08T09:18:15Z

utils/default_styles.js

 const lines_defaultColor = { r: 20, g: 20, b: 20 }
 const surfaces_defaultVisibility = true
-const surfaces_defaultColor = { r: 20, g: 20, b: 20 }
+const surfaces_defaultColor = { r: 255, g: 255, b: 255 }


_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

github-actions · 2025-11-08T09:18:15Z

utils/default_styles.js

 const lines_defaultColor = { r: 20, g: 20, b: 20 }
 const surfaces_defaultVisibility = true
-const surfaces_defaultColor = { r: 20, g: 20, b: 20 }
+const surfaces_defaultColor = { r: 255, g: 255, b: 255 }


_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

github-actions · 2025-11-08T09:18:15Z

utils/default_styles.js

+const surfaces_defaultColor = { r: 255, g: 255, b: 255 }
 const blocks_defaultVisibility = true
-const blocks_defaultColor = { r: 20, g: 20, b: 20 }
+const blocks_defaultColor = { r: 255, g: 255, b: 255 }


_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

github-actions · 2025-11-08T09:18:15Z

utils/default_styles.js

+const surfaces_defaultColor = { r: 255, g: 255, b: 255 }
 const blocks_defaultVisibility = true
-const blocks_defaultColor = { r: 20, g: 20, b: 20 }
+const blocks_defaultColor = { r: 255, g: 255, b: 255 }


_{reported by reviewdog 🐶}
Identifier name is too short (< 2).

github-actions · 2025-11-08T09:18:16Z

stores/hybrid_viewer.js

+          view_up: Array.from(camera.getViewUp()),
+          position: Array.from(camera.getPosition()),
+          view_angle: camera.getViewAngle(),
+          clipping_range: Array.from(camera.getClippingRange()),


_{reported by reviewdog 🐶}
Prefer the spread operator (...) over Array.from()

github-actions · 2025-11-08T09:18:18Z

stores/data_base.js

+  function exportStores() {
+    const snapshotDb = {}
+    for (const [id, item] of Object.entries(db)) {
+      if (!item) continue


_{reported by reviewdog 🐶}
Expected { after 'if' condition.

github-actions · 2025-11-08T09:18:18Z

stores/data_base.js

    return flat_indexes
  }

+  function exportStores() {


_{reported by reviewdog 🐶}
Expected a function expression.

github-actions · 2025-11-08T09:18:18Z

stores/data_base.js

+    return { db: snapshotDb }
+  }
+
+  async function importStores(snapshot) {


_{reported by reviewdog 🐶}
Expected a function expression.

github-actions · 2025-11-08T09:18:18Z

stores/data_base.js

+    }
+  }
+
+  function clear() {


_{reported by reviewdog 🐶}
Expected a function expression.

github-actions · 2025-11-08T09:21:03Z

stores/hybrid_viewer.js

+    }
+
+    const camera_options = snapshot?.camera_options
+    if (!camera_options) return


_{reported by reviewdog 🐶}
Expected { after 'if' condition.

github-actions · 2025-11-08T09:21:03Z

stores/hybrid_viewer.js

+      await setZScaling(z_scale)
+    }
+
+    const camera_options = snapshot?.camera_options


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-08T09:21:03Z

stores/data_base.js

+      Object.keys(snapshot?.db || {}),
+    )
+    for (const [id, item] of Object.entries(snapshot?.db || {})) {
+      await registerObject(id)


_{reported by reviewdog 🐶}
Unexpected await inside a loop.

github-actions · 2025-11-08T09:21:03Z

stores/data_base.js

+    )
+    for (const [id, item] of Object.entries(snapshot?.db || {})) {
+      await registerObject(id)
+      await addItem(id, item)


_{reported by reviewdog 🐶}
Unexpected await inside a loop.

github-actions · 2025-11-08T09:21:03Z

stores/data_base.js

+  async function importStores(snapshot) {
+    await hybridViewerStore.initHybridViewer()
+    hybridViewerStore.clear()
+    console.log(


_{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2025-11-08T09:21:03Z

stores/data_base.js

+  function exportStores() {
+    const snapshotDb = {}
+    for (const [id, item] of Object.entries(db)) {
+      if (!item) continue


_{reported by reviewdog 🐶}
Unexpected use of continue statement.

github-actions · 2025-11-08T09:21:03Z

stores/data_base.js

+    return { db: snapshotDb }
+  }
+
+  async function importStores(snapshot) {


_{reported by reviewdog 🐶}
async is not allowed

github-actions · 2025-11-08T09:21:03Z

stores/data_base.js

+        viewable_filename: item.viewable_filename,
+        displayed_name: item.displayed_name,
+        vtk_js: {
+          binary_light_viewable: item?.vtk_js?.binary_light_viewable,


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-08T09:21:03Z

stores/data_base.js

+    hybridViewerStore.clear()
+    console.log(
+      "[DataBase] importStores entries:",
+      Object.keys(snapshot?.db || {}),


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-08T09:21:04Z

stores/data_base.js

+      "[DataBase] importStores entries:",
+      Object.keys(snapshot?.db || {}),
+    )
+    for (const [id, item] of Object.entries(snapshot?.db || {})) {


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-08T09:32:02Z

stores/data_style.js

+  async function importStores(snapshot) {
+    const stylesSnapshot = snapshot?.styles || {}
+    for (const id of Object.keys(dataStyleState.styles))
+      delete dataStyleState.styles[id]


_{reported by reviewdog 🐶}
Expected { after 'for-of'.

github-actions · 2025-11-08T09:32:02Z

stores/data_style.js

+      const meta = dataBaseStore.itemMetaDatas(id)
+      const objectType = meta?.object_type
+      const style = dataStyleState.styles[id]
+      if (!style || !objectType) continue


_{reported by reviewdog 🐶}
Expected { after 'if' condition.

github-actions · 2025-11-08T09:32:02Z

stores/data_style.js

+    return Promise.resolve([])
+  }
+
+  function setModelEdgesVisibility(id, visibility) {


_{reported by reviewdog 🐶}
Expected a function expression.

github-actions · 2025-11-08T09:32:02Z

stores/data_style.js

+    return modelStyleStore.setModelEdgesVisibility(id, visibility)
+  }
+
+  function modelEdgesVisibility(id) {


_{reported by reviewdog 🐶}
Expected a function expression.

github-actions · 2025-11-08T09:32:02Z

stores/data_style.js

+    return modelStyleStore.modelEdgesVisibility(id)
+  }
+
+  function exportStores() {


_{reported by reviewdog 🐶}
Expected a function expression.

github-actions · 2025-11-08T09:32:03Z

stores/data_style.js

 import useDataStyleState from "../internal_stores/data_style_state.js"
 import useMeshStyle from "../internal_stores/mesh/index.js"
 import useModelStyle from "../internal_stores/model/index.js"
+import { getDefaultStyle } from "../utils/default_styles.js"


_{reported by reviewdog 🐶}
Imports should be sorted alphabetically.

github-actions · 2025-11-08T09:32:03Z

stores/data_style.js

+    return { styles: dataStyleState.styles }
+  }
+
+  async function importStores(snapshot) {


_{reported by reviewdog 🐶}
async is not allowed

github-actions · 2025-11-08T09:32:03Z

stores/data_style.js

+    }
+  }
+
+  async function applyAllStylesFromState() {


_{reported by reviewdog 🐶}
async is not allowed

github-actions · 2025-11-08T09:32:03Z

stores/data_style.js

+  }
+
+  async function importStores(snapshot) {
+    const stylesSnapshot = snapshot?.styles || {}


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

github-actions · 2025-11-08T09:32:03Z

stores/data_style.js

+    const ids = Object.keys(dataStyleState.styles || {})
+    for (const id of ids) {
+      const meta = dataBaseStore.itemMetaDatas(id)
+      const objectType = meta?.object_type


_{reported by reviewdog 🐶}
Optional chaining is not allowed.

feat(save_and_load): add save/load methods to all stores for project …

aa86c91

…persistence create project manager plugin for import/export operations update tests for new functionality and async loading

MaxNumerique requested a review from JulienChampagnol October 28, 2025 08:10

MaxNumerique and others added 6 commits October 28, 2025 08:11

Apply prepare changes

5b2b4f3

cartStore becomes geodeStore

f4ef491

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

5f3e0c6

…ns/OpenGeodeWeb-Front into feat/save_and_load

Apply prepare changes

e6c54b5

renames and move tests

01a9732

Merge branch 'next' of https://github.com/Geode-solutions/OpenGeodeWe…

0b70454

…b-Front into feat/save_and_load

BotellaA reviewed Oct 28, 2025

View reviewed changes

MaxNumerique and others added 8 commits October 29, 2025 10:31

persist upload folder

d577721

renamed app_store store to app

df419ec

rm unused var

bb9d02d

importStore & exportStore refacto

a93225c

Apply prepare changes

af41f9d

testes with import/export

ea63e2b

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

97072b5

…ns/OpenGeodeWeb-Front into feat/save_and_load

Apply prepare changes

63464b7

MaxNumerique changed the title ~~feat(save_and_load): add save/load methods to all stores for project …~~ feat(save_and_load): add import/export methods to all stores for project … Oct 30, 2025

MaxNumerique changed the title ~~feat(save_and_load): add import/export methods to all stores for project …~~ feat(save_and_load): add import/export methods Oct 30, 2025

MaxNumerique requested a review from BotellaA October 30, 2025 15:40

MaxNumerique and others added 6 commits October 30, 2025 17:02

test

98991cf

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

6321c8f

…ns/OpenGeodeWeb-Front into feat/save_and_load

Apply prepare changes

35c75dd

test

22a67fe

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

caf5a39

…ns/OpenGeodeWeb-Front into feat/save_and_load

Apply prepare changes

18fc885

BotellaA reviewed Oct 30, 2025

View reviewed changes

JulienChampagnol approved these changes Oct 31, 2025

View reviewed changes

composables/project_manager.js Outdated Show resolved Hide resolved

composables/project_manager.js Outdated Show resolved Hide resolved

tests/unit/plugins/ProjectLoad.nuxt.test.js Outdated Show resolved Hide resolved

stores/data_base.js Outdated Show resolved Hide resolved

MaxNumerique and others added 2 commits October 31, 2025 11:46

exportStores/importStores and createTestingPinia

d4a1cd6

Apply prepare changes

8aec8b8

github-actions bot reviewed Nov 7, 2025

View reviewed changes

MaxNumerique added 2 commits November 7, 2025 12:25

revert internal_stores

5f65391

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

a1725f8

…ns/OpenGeodeWeb-Front into feat/save_and_load

github-actions bot reviewed Nov 7, 2025

View reviewed changes

MaxNumerique added 2 commits November 7, 2025 12:26

revert

f6e73f2

viewer_call

309b5f4

github-actions bot reviewed Nov 7, 2025

View reviewed changes

MaxNumerique and others added 5 commits November 7, 2025 15:44

Merge branch 'next' of https://github.com/Geode-solutions/OpenGeodeWe…

cdbee18

…b-Front into feat/save_and_load

Apply prepare changes

7ab0049

logs everywhere

7a0e43e

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

9954c87

…ns/OpenGeodeWeb-Front into feat/save_and_load

Apply prepare changes

933cb71

github-actions bot reviewed Nov 7, 2025

View reviewed changes

MaxNumerique and others added 7 commits November 7, 2025 16:44

revert some

e0cf657

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

2f464bb

…ns/OpenGeodeWeb-Front into feat/save_and_load

Apply prepare changes

44a70fe

please

499fc4b

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

c0df47c

…ns/OpenGeodeWeb-Front into feat/save_and_load

OMGGGGG

fca8a2a

Apply prepare changes

28abd57

github-actions bot reviewed Nov 7, 2025

View reviewed changes

MaxNumerique added 2 commits November 7, 2025 23:12

test

c156eab

Merge branch 'feat/save_and_load' of https://github.com/Geode-solutio…

e6d2c43

…ns/OpenGeodeWeb-Front into feat/save_and_load

github-actions bot reviewed Nov 7, 2025

View reviewed changes

fix : brep imports

17607da

github-actions bot reviewed Nov 8, 2025

View reviewed changes

renames

9853aab

github-actions bot reviewed Nov 8, 2025

View reviewed changes

brep fix

5232228

github-actions bot reviewed Nov 8, 2025

View reviewed changes

		@@ -0,0 +1,129 @@
		import { beforeEach, describe, expect, test, vi } from "vitest"

feat(save_and_load): add import/export methods #249

Are you sure you want to change the base?

feat(save_and_load): add import/export methods #249

Uh oh!

Conversation

MaxNumerique commented Oct 28, 2025

Uh oh!

BotellaA Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

MaxNumerique Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

MaxNumerique Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

BotellaA Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

MaxNumerique Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

BotellaA Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 7, 2025