Allowing async PDF parser
#1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
MicPie,
maykcaldas,
mskarlin,
nadolskit,
sidnarayanan and
whitead
dosubot
bot
added
the
size:M
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Copilot finished reviewing on behalf of
jamesbraza
November 17, 2025 22:33
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the PDF parsing infrastructure to support both synchronous and asynchronous PDF parsers, allowing greater flexibility in how PDFs are processed.
Key Changes:
- Introduces separate protocol definitions for sync (
SyncPDFParserFn) and async (AsyncPDFParserFn) PDF parsers - Updates
read_docto detect and handle both sync and async PDF parsers using runtime inspection - Modifies the Zotero integration to handle async parser results
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/paperqa/readers.py | Splits PDFParserFn into separate sync/async protocols and adds runtime detection logic in read_doc to handle both types |
| src/paperqa/contrib/zotero.py | Adds handling for async PDF parser results in the iterate method using asyncio.run() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamesbraza
force-pushed
the
async-reader
branch
from
9e492b5 to
80a24f0
Compare
maykcaldas
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brief refactor moves our reader layer to allow for
asyncreaders.