Clear stored data when deleting accounts #207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves account deletion by ensuring complete data cleanup when users delete their accounts. The changes clear stored preferences and utilize the existing sign-out flow for proper token cleanup and event emission.
- Clears both
user_preferencesandFreshKeeperPrefsshared preferences during account deletion - Replaces direct
auth.signOut()call with existingsignOut()method to leverage proper cleanup flow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
app/src/main/java/com/freshkeeper/service/account/AccountServiceImpl.kt
Outdated
Show resolved
Hide resolved
| .edit { | ||
| clear() | ||
| } | ||
|
|
There was a problem hiding this comment.
[nitpick] The preference clearing logic is duplicated for both shared preferences. Consider extracting this into a helper method that accepts the preference name as a parameter to reduce code duplication.
Suggested change
| clearPreferences("user_preferences") | |
| clearPreferences("FreshKeeperPrefs") |
…ceImpl.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
user_preferencesandFreshKeeperPrefswhen deleting accountsTesting
./gradlew test(fails: /workspace/AndroidApp/app/keys.properties (No such file or directory))https://chatgpt.com/codex/tasks/task_b_68a7156c46188327b939c8cb0e7128da