Store barcode only when used #202
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements conditional barcode storage to avoid persisting empty barcode values in the database. The change ensures that barcodes are only stored when they contain meaningful data.
- Introduces null-safe barcode cleaning to filter out blank values
- Replaces direct FoodItem object persistence with a Map-based approach for selective field inclusion
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| barcode = cleanedBarcode, | ||
| userId = user.id, | ||
| householdId = householdId, | ||
| name = productName, |
There was a problem hiding this comment.
The FoodItem object is created but never used after line 119 switches to using foodItemData. This creates unnecessary object instantiation and potential confusion about which data structure is actually persisted.
| category = category, | ||
| status = FoodStatus.ACTIVE, | ||
| picture = picture, | ||
| ) |
There was a problem hiding this comment.
The FoodItem object is created but never used after line 119 switches to using foodItemData. This creates unnecessary object instantiation and potential confusion about which data structure is actually persisted.
| cleanedBarcode?.let { this["barcode"] = it } | ||
| householdId?.let { this["householdId"] = it } | ||
| picture?.let { this["picture"] = it } | ||
| } |
There was a problem hiding this comment.
The hardcoded string keys in the map create a maintenance risk and potential for typos. Consider using property names from the FoodItem class or defining constants for these field names to ensure consistency.
Summary
Testing
./gradlew test(fails: keys.properties missing)https://chatgpt.com/codex/tasks/task_b_68a70f5e974883279bff6a680fd95519