feat: get evaluation get result #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaimwa9
commented
Oct 28, 2025
Comment on lines
84
to
91
| 'Integer' => ->(v) { | ||
| i = v.to_i; | ||
| i.to_s == v.to_s ? i : v | ||
| }, | ||
| 'Float' => ->(v) { | ||
| f = v.to_f; | ||
| f.to_s == v.to_s ? f : v | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This implementation is problematic and was fixed in incoming PR.
This would end up coerciting 123abc to 123abc 🔴
Zaimwa9
commented
Oct 28, 2025
Zaimwa9
changed the title
…h/flagsmith-ruby-client into feat/evaluation-get-result
khvn26
reviewed
Nov 3, 2025
khvn26
reviewed
Nov 3, 2025
…h/flagsmith-ruby-client into feat/evaluation-get-result
…h/flagsmith-ruby-client into feat/evaluation-get-result
gagantrivedi
approved these changes
Nov 11, 2025
khvn26
approved these changes
Nov 11, 2025
gagantrivedi
approved these changes
Nov 12, 2025
* fix: sdk-uses-new-engine-methods * feat: introduced-jsonpath-library * feat: fixed-conflict * Update lib/flagsmith/engine/segments/models.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * Update lib/flagsmith/engine/segments/models.rb * feat: removed-normalize * feat: linter * feat: replaced-flagsmith-id-with-id * feat: removed-comments --------- Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
Zaimwa9
added a commit
that referenced
this pull request
Nov 12, 2025
* fix: main-mappers-and-tests * fix: added-metadata * fix: renaming * fix: comments * fix: remoevd-redundant-test * feat: reviewed-engine-test-todos * Update lib/flagsmith/engine/evaluation/mappers.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * feat: use-overrides-key-hash * feat: removed-identifiers-join * feat: flagsmith-id-in-snake-case * feat: run-lint * feat: renamed-module-evaluation * feat: fixed-priority-0-being-skipped * feat: reverted-to-hash * feat: linter * feat: split-functions-and-module-for-linting * feat: get-rid-of-extra-map-nested-rule-function * feat: renaming-identity-methods * feat: fixed-forgotten-func-renaming * Update lib/flagsmith/engine/evaluation/mappers/environment.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * feat: added-name-env-model-and-fixture * feat: moved-mappers-to-engine-namespace * feat: removed-feature-key * feat: linter * feat: get evaluation get result (#88) * feat: added-engine-function-signatures * feat: moved-engine-to-core * feat: implemented-process-segment-overrides * feat: implemented-evalute-segments-partially * feat: implemented-should-apply-override * feat: implemented-get-identity-segments * feat: implemented-new-in-and-fixed-remaining-tests * feat: run-lint * feat: misc * feat: json-path-lib-implementation * remove dup * feat: made-legacy-functions-public * feat: updated-tests-to-match-engine-in-operator-accepting-numbers * feat: engine-agnostic-to-empty-identity-in-segment-evaluation * feat: renamed-to-is-higher-priority * feat: renamed-get-identity-segments-func * feat: reverted-to-is-primitive * feat: use-weakest-priority-constant * feat: upgraded-engine-test-data-and-fixed-mv-evaluation-bug * feat: removed-targeting-reason-func * feat: linter-rubocop-autocorrect * feat: linter * feat: linter * feat: moved-mappers-to-engine-namespace * feat: enrich-context-with-identity-key * feat: run-ci-on-all-branches * feat: removed-comments * feat!: sdk consumes context engine (#89) * fix: sdk-uses-new-engine-methods * feat: introduced-jsonpath-library * feat: fixed-conflict * Update lib/flagsmith/engine/segments/models.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * Update lib/flagsmith/engine/segments/models.rb * feat: removed-normalize * feat: linter * feat: replaced-flagsmith-id-with-id * feat: removed-comments --------- Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> --------- Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com> Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> --------- Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.