another batch of instanceof changes #5391
Open
+233
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjfanning
commented
Nov 13, 2025
pjfanning
commented
- follow up to use instanceof that avoids explicit cast #5390
- there are probably changes that can be made in test code and also some changes in main source but the remaining instances there often involve fairly big reordering of the code
some more more uses of instanceof
pjfanning
commented
Nov 13, 2025
| if (ann instanceof AnnotatedClass) { | ||
| JsonTypeInfo.As inclusion = typeInfo.getInclusionType(); | ||
| if (inclusion == JsonTypeInfo.As.EXTERNAL_PROPERTY && (ann instanceof AnnotatedClass)) { | ||
| if (inclusion == JsonTypeInfo.As.EXTERNAL_PROPERTY) { |
Member
Author
There was a problem hiding this comment.
same instanceof checked 2 lines earlier
cowtowncoder
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.