Docker image building will fail due to utoipa git url dependencies #8666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts [commit](ElementsProject@cd1ec72), as an alternative fix has already been introduced in PR [ElementsProject#8547](ElementsProject#8547) to restore reproducible builds. This reversion is necessary because otherwise Docker image building will fail with GitHub Actions or via build-release.sh. The issue arises from Cargo’s inability to resolve the git URL dependencies for clnrest’s utoipa and utoipa-swagger-ui packages within these build contexts. While direct `docker buildx` commands succeeds, Github Action or build-release.sh modifies the build context in a way that prevents Cargo from locating the specific git commit for these dependencies. References: ElementsProject#8530 (comment) https://github.com/ElementsProject/lightning/actions/runs/17435823432 Added fixed SOURCE_DATE_EPOCH flag for reproducible ubuntu builds [8547](ElementsProject#8547) Changelog-None.
Collaborator
|
The Rust crate Release Action also refuses to publish any crate while clnrest has git dependencies, a bit silly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit, as an alternative fix has already been introduced in PR #8547 to restore reproducible builds.
This reversion is necessary otherwise Docker image building will fail with GitHub Actions or via build-release.sh. The issue arises from Cargo’s inability to resolve the git URL dependencies for clnrest’s utoipa and utoipa-swagger-ui packages within these build contexts. While direct
docker buildxcommands succeeds, Github Action or build-release.sh modifies the build context in a way that prevents Cargo from locating the specific git commit for these dependencies.References:
Discussion
Failed Action
PR with the fix
Changelog-None.