feat: add fallback commands #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a corresponding fallback command for each web search shortcut, allowing users to type directly on the Command Palette home page and search with the selected engine.
Motivation
Key Changes
Add
FallbackSearchWebItem: wrapsSearchWebCommandand adds the "Open home page" command toMoreCommands.Behavioral parity: matches the existing SearchWebCommand and provides the "Open home page" action with the same title/subtitle format.
Implement
FallbackCommands()inWebSearchShortcutCommandsProviderand create oneFallbackSearchWebItemper shortcut at load time.