Skip to content

Conversation

@Masterain98
Copy link
Member

Summary

  • add a repository-wide AGENTS.md describing build, localization, and dependency policies
  • define solution-level instructions under src/Snap.Hutao
  • document project and subsystem guidelines for Core, Service, Web, UI, ViewModel, and other major folders, including tests and resources

Testing

  • not run

https://chatgpt.com/codex/tasks/task_b_68fc902032e88321884591df939fc392

Copilot AI review requested due to automatic review settings October 25, 2025 09:18
@dgp-bot
Copy link

dgp-bot bot commented Oct 25, 2025

Summary of Pull Request

This PR by Masterain introduces scoped agent guidelines for the Snap Hutao repository. It adds an AGENTS.md file to various directories within the project.

Changes by feature
  • General:

    • Created a root-level AGENTS.md file.
    • Created a res/AGENTS.md file.
    • Created a src/Snap.Hutao/AGENTS.md file.
  • Test Project:

    • Created a src/Snap.Hutao/Snap.Hutao.Test/AGENTS.md file.
  • Main Application:

    • Created a src/Snap.Hutao/Snap.Hutao/AGENTS.md file.
  • Core:

    • Created a src/Snap.Hutao/Snap.Hutao/Core/AGENTS.md file.
  • Extension:

    • Created a src/Snap.Hutao/Snap.Hutao/Extension/AGENTS.md file.
  • Factory:

    • Created a src/Snap.Hutao/Snap.Hutao/Factory/AGENTS.md file.
  • Migrations:

    • Created a src/Snap.Hutao/Snap.Hutao/Migrations/AGENTS.md file.
  • Model:

    • Created a src/Snap.Hutao/Snap.Hutao/Model/AGENTS.md file.
  • Resource:

    • Created a src/Snap.Hutao/Snap.Hutao/Resource/AGENTS.md file.
  • Service:

    • Created a src/Snap.Hutao/Snap.Hutao/Service/AGENTS.md file.
  • UI:

    • Created a src/Snap.Hutao/Snap.Hutao/UI/AGENTS.md file.
  • ViewModel:

    • Created a src/Snap.Hutao/Snap.Hutao/ViewModel/AGENTS.md file.
  • Web:

    • Created a src/Snap.Hutao/Snap.Hutao/Web/AGENTS.md file.
  • Win32:

    • Created a src/Snap.Hutao/Snap.Hutao/Win32/AGENTS.md file.

Key Change Highlights

  • The addition of AGENTS.md files across the project structure suggests the introduction or formalization of guidelines related to agents within the Snap Hutao application. The specific content of these files is not available in the provided patch, but their presence indicates a focused effort on managing and defining agent behavior or responsibilities within different modules of the application. Without knowing the context of the files, it's impossible to determine the impact of overall codebase.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive set of scoped agent guidelines (AGENTS.md files) throughout the Snap Hutao repository to provide targeted context for AI coding assistants. The guidelines establish consistent coding standards, architectural patterns, and best practices at multiple levels - from repository-wide policies down to individual subsystem requirements.

Key Changes:

  • Establishes repository-wide development standards for dependencies, code style, localization, and testing
  • Defines solution-level build and configuration requirements
  • Documents project-specific guidelines for major architectural layers (Core, Service, Web, UI, ViewModel, Model, etc.)

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
AGENTS.md Repository root guidelines covering project positioning, global development standards, workflow, and PR conventions
res/AGENTS.md Guidelines for non-packaged design and promotional assets in the res directory
src/Snap.Hutao/AGENTS.md Solution-level guidelines for build configuration, NuGet management, and file organization
src/Snap.Hutao/Snap.Hutao.Test/AGENTS.md Test project standards for MSTest framework usage, structure, and coverage requirements
src/Snap.Hutao/Snap.Hutao/AGENTS.md Main app project architectural principles covering MVVM, WinUI/XAML, performance, and localization
src/Snap.Hutao/Snap.Hutao/Core/AGENTS.md Core infrastructure layer guidelines for cross-cutting concerns, performance optimization, and dependency restrictions
src/Snap.Hutao/Snap.Hutao/Extension/AGENTS.md Extension methods standards emphasizing generality, documentation, and dependency limitations
src/Snap.Hutao/Snap.Hutao/Factory/AGENTS.md Factory pattern guidelines for object creation, testability, and dependency injection
src/Snap.Hutao/Snap.Hutao/Migrations/AGENTS.md EF Core migration management practices and naming conventions
src/Snap.Hutao/Snap.Hutao/Model/AGENTS.md Model layer design principles for domain data, nullability handling, and documentation
src/Snap.Hutao/Snap.Hutao/Resource/AGENTS.md Resource directory organization covering localization, images, and version control practices
src/Snap.Hutao/Snap.Hutao/Service/AGENTS.md Service layer responsibilities including DI patterns, async operations, and testing requirements
src/Snap.Hutao/Snap.Hutao/UI/AGENTS.md UI layer standards for XAML, code-behind, performance, and accessibility
src/Snap.Hutao/Snap.Hutao/ViewModel/AGENTS.md ViewModel MVVM patterns, async command handling, and state management
src/Snap.Hutao/Snap.Hutao/Web/AGENTS.md Web layer specifications for HTTP clients, DTOs, JSON serialization, and WebView2 integration
src/Snap.Hutao/Snap.Hutao/Win32/AGENTS.md Win32 interop standards for P/Invoke, resource management, and error handling

@Masterain98 Masterain98 changed the base branch from main to develop October 25, 2025 09:18
@Lightczx
Copy link
Member

Lightczx commented Oct 25, 2025

Generally all test related text should be removed.
WinUI3 currently not support test project.

Deleted .github/copilot-instructions.md and revised AGENTS.md files across the repository for improved clarity, consistency, and maintainability. Updates include enhanced localization instructions, clarified validation and testing requirements, and refined coding and contribution guidelines. These changes ensure better alignment with current development practices and repository policies.
@Masterain98 Masterain98 requested a review from Lightczx October 25, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants