Skip to content

Conversation

@gotztibor
Copy link

…luation and Microsoft.Build.Locator instead of direct xml parsing of csproj files.

…luation and Microsoft.Build.Locator instead of direct xml parsing of csproj files.
@gotztibor gotztibor requested a review from a team as a code owner September 2, 2025 11:11
@gotztibor gotztibor changed the title Evaluation of project properties with the help of Microsoft.Build.Eva… #Issue 669 - Evaluation of project properties with the help of Microsoft.Build.Eva… Sep 2, 2025
@gotztibor
Copy link
Author

Sorry, because of the mocked filesystem, the relative path resolution is not working for msbuild, and causing problems...
I need somehow to rework that! :(

@mtsfoni
Copy link
Member

mtsfoni commented Oct 7, 2025

We previously called getProperty via the CLI:
https://github.com/CycloneDX/cyclonedx-dotnet/pull/952/files#diff-efdf0376edc6212a3bf9fda75a718e277085602f7a61c2c4bcdd72ad0b2f2b82

I assume this works the same, just implemented in a cleaner way through a package instead of the CLI?
One thing to keep in mind: the first implementation in that commit had a significant performance impact on large solutions.
Have you tested this approach with bigger solutions to confirm performance is acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants