-
-
Notifications
You must be signed in to change notification settings - Fork 111
Added NugetConfigFileService, parsing nuget.config for package sources #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added NugetConfigFileService, parsing nuget.config for package sources #921
Conversation
Allow package lookup from a list of repositories
Signed-off-by: Georg Rottensteiner <georg@georg-rottensteiner.de>
Merge in VAS/cyclonedx-fork from feature/fix_nuget_zip_crash to master * commit 'defa3ac1fa89ce0fe67f045573ef4d100883d058': Fix Codacy "issues" Signed-off-by: Georg Rottensteiner <georg@georg-rottensteiner.de> Added NugetConfigFileService, parsing nuget.config for package sources Allow package lookup from a list of repositories
|
Is this related to #904? Could you give me a little more context before I review? Also you need to sign off your commits. Here is also a detailed guide how to retrospectively: https://github.com/CycloneDX/cyclonedx-dotnet/pull/921/checks?check_run_id=35933831961 |
|
Looks like it. The issue is that NuGet.Protocol returns a non-null Stream object even if there is no file at all. Also as a hint: I did not add package source authentication, albeit the models allowing for such. I did more or less the bare minimum to get it working for my use case. If that method works that might be something that ought to be added. Will look into that signing off asap! |
Allow package lookup from a list of repositories Modified commit message to include signoff: Signed-off-by: Georg Rottensteiner <georg@georg-rottensteiner.de>
Signed-off-by: Georg Rottensteiner <georg@georg-rottensteiner.de>
defa3ac to
f8ac92e
Compare
|
Not sure if I did that correctly, I have a 50% miss rate with rebasing :) Need that StringBuilder issue Codacy bemoans also rectified? |
Signed-off-by: Georg Rottensteiner <georg@georg-rottensteiner.de>
|
I wanted to explain the other part I modified: |
|
I think I understand and after skimming briefly the code looks good so far. I'd like to set up an environment to recreate the problem and test your solution, as that is some work, it might take a little before I integrate this PR. |
…gRottensteiner/cyclonedx-dotnet into feature/fix_nuget_zip_crash
…nedx-dotnet into feature/fix_nuget_zip_crash
…\DotnetToolSettings.xml issues otherwise
Allow package lookup from a list of repositories