Skip to content

Conversation

@thompson-tomo
Copy link

@thompson-tomo thompson-tomo commented Jan 29, 2024

This request now sets:

  • the publisher in the sbom based on the owner and if it is null it will use the author

Closes #842

Signed-off-by: James Thompson <thompson.tomo@outlook.com>
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
@thompson-tomo thompson-tomo force-pushed the enhancement/#842_SetPublisher branch from bc9818c to 6aedc89 Compare January 30, 2024 10:29
@mtsfoni
Copy link
Member

mtsfoni commented Jan 30, 2024

I'm not quite convinced the owner should be filled with the author. Can you explain your reasoning for it? Is it regarding some national regulations?

@thompson-tomo
Copy link
Author

@mtsfoni as per the nuspec reference on microsoft (https://learn.microsoft.com/en-us/nuget/reference/nuspec) owners is deprecated and instead should use authors moving forward.

Signed-off-by: James Thompson <thompson.tomo@outlook.com>
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
@thompson-tomo thompson-tomo force-pushed the enhancement/#842_SetPublisher branch from cb2d037 to d06386a Compare January 30, 2024 21:23
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
@thompson-tomo thompson-tomo force-pushed the enhancement/#842_SetPublisher branch from 39b25f7 to 5472d5e Compare January 30, 2024 21:37
@thompson-tomo thompson-tomo marked this pull request as ready for review March 12, 2024 21:53
@thompson-tomo thompson-tomo requested a review from a team as a code owner March 12, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set additional properties when generating sbom for nugets

2 participants