Skip to content

Conversation

@rukai
Copy link

@rukai rukai commented Nov 3, 2025

Mostly I just want to remove lazy_static from my dep tree, and colored 3.0.0 has removed its dependency on lazy_static.

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025

CodSpeed Performance Report

Merging #142 will degrade performances by 50%

Comparing rukai:update_colored (58111d5) with main (e5597da)

Summary

⚡ 17 improvements
❌ 10 regressions
✅ 283 untouched
🆕 22 new
⏩ 43 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime bench_array1[1] 1 ns 2 ns -50%
WallTime bench_array2[1] 1 ns 2 ns -50%
Simulation sleep_100ms 566.1 ns 536.9 ns +5.43%
Simulation sleep_100ms_with_custom_sample 566.1 ns 536.9 ns +5.43%
Simulation sleep_10ms 566.1 ns 536.9 ns +5.43%
Simulation sleep_1ms 566.1 ns 536.9 ns +5.43%
Simulation sleep_50ms 566.1 ns 536.9 ns +5.43%
🆕 Simulation slice_into_vec_with_bytes N/A 642.8 ns N/A
🆕 WallTime slice_into_vec_with_bytes N/A 59 ns N/A
🆕 WallTime string_copy_with_bytes_counter N/A 61 ns N/A
🆕 Simulation string_copy_with_bytes_counter N/A 798.1 ns N/A
🆕 Simulation vec_copy_with_bytes_counter N/A 887.5 ns N/A
🆕 WallTime vec_copy_with_bytes_counter N/A 82 ns N/A
🆕 Simulation count_chars_in_string N/A 701.1 ns N/A
🆕 WallTime count_chars_in_string N/A 34 ns N/A
🆕 Simulation uppercase_chars_with_counter N/A 2.1 µs N/A
🆕 WallTime uppercase_chars_with_counter N/A 352 ns N/A
🆕 WallTime hash_computation_cycles N/A 48 ns N/A
🆕 Simulation hash_computation_cycles N/A 512.5 ns N/A
🆕 Simulation simulated_processing_cycles N/A 2 µs N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@GuillaumeLagrange
Copy link
Contributor

@rukai tests are failing but no action on your part is required, we have a msrv bump to decide on, and the other one is CI flakiness on this repo that we need to fix.
Thanks for your PR, we'll get this merged or ping you if we require anything

@GuillaumeLagrange
Copy link
Contributor

GuillaumeLagrange commented Nov 5, 2025

Hello!

As merging this would require us to raise the rust msrv of the core and the criterion compatibilty crate, we've decided not to merge this for now if the benefit is only getting rid of lazy static.

Next codspeed-rust major is probably when we'll bump msrv to 1.80 since criterion did so upstream and divan already has an 1.80 msrv. We'll keep this open until then unless bumping is required to fix a security issue or if there's a more compelling argument than just getting rid of lazy static.

@GuillaumeLagrange GuillaumeLagrange removed their request for review November 5, 2025 09:30
@rukai
Copy link
Author

rukai commented Nov 5, 2025

Oh, oops I didn't realize colored had bumped it's msrv, totally understandable. Feel free to keep the pr open until you bump your msrv, or feel free to close it for now and just update your deps together once you do bump msrv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants