Skip to content

[ENG-9653] Improved logging with traceback and stack variables for embargo_registrations script #11422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/pbs-25-21
Choose a base branch
from
+25 −5
Open

[ENG-9653] Improved logging with traceback and stack variables for embargo_registrations script #11422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a407af
added stack variables and traceback for embargo_registration script i…
ihorsokhanexoft Nov 4, 2025
56dd6dc
returned old statement
ihorsokhanexoft Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions scripts/embargo_registrations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from framework.celery_tasks import app as celery_app

from website import settings
from osf.models import Embargo, Registration, NodeLog
from osf.models import Embargo, Registration

from scripts import utils as scripts_utils

Expand Down Expand Up @@ -59,12 +59,22 @@ def main(dry_run=True):
embargo.accept()
transaction.savepoint_commit(sid)
except Exception as err:
root = parent_registration._dirty_root
embargo = root.embargo

logger.error(
f'Unexpected error raised when activating embargo for '
f'registration {parent_registration._id}. Continuing...'
f'registration {parent_registration._id}. Error: {err}',
exc_info=err,
extra={
'is_public': root.is_public,
'approval_stage': embargo.approval_stage.name,
'is_approved': root.embargo.is_approved
}
)
logger.exception(err)
sentry.log_message(str(err))
sentry.log_exception(err)

transaction.savepoint_rollback(sid)

active_embargoes = Embargo.objects.filter(state=Embargo.APPROVED)
Expand All @@ -89,11 +99,21 @@ def main(dry_run=True):
parent_registration.terminate_embargo()
transaction.savepoint_commit(sid)
except Exception as err:
root = parent_registration._dirty_root
embargo = root.embargo

logger.error(
f'Registration {parent_registration._id} could not be made public because {str(err)}',
exc_info=err
exc_info=err,
extra={
'is_public': root.is_public,
'approval_stage': embargo.approval_stage.name,
'is_approved': root.embargo.is_approved
}
)
sentry.log_message(f'Registration {parent_registration._id} could not be made public because {str(err)}')
logger.exception(err)
sentry.log_exception(err)

transaction.savepoint_rollback(sid)


Expand Down
Loading