Skip to content

Conversation

@jbhanuchand
Copy link

@jbhanuchand jbhanuchand commented Oct 29, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings October 29, 2025 12:05
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @jbhanuchand,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Hi @jbhanuchand

Release Suggestions

Module: datadog

  • Please log updates into to src/datadog/HISTORY.rst
  • Update VERSION to 3.0.0 in src/datadog/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Datadog Azure CLI extension from version 2.0.0 to 2.1.0, primarily updating the API version from 2021-03-01/2023-10-20 to 2025-06-11. Key changes include:

  • Upgraded API version to 2025-06-11 across all commands
  • Added new monitored-subscription and subscription-status command groups
  • Enhanced monitor configuration with resource_collection property
  • Added agent_rules, automuting, and custom_metrics to tag rules
  • Improved argument validation with pattern matching and length constraints
  • Changed sensitive fields from AAZStrArg to AAZPasswordArg for better security
  • Added get-billing-info command to retrieve marketplace and organization billing information

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
setup.py Version bumped from 2.0.0 to 2.1.0
azext_metadata.json Minimum CLI core version updated to 2.75.0
terms/*.py API version updated to 2025-06-11, added datetime format and required flag
tag_rule/*.py API version updated, added agent_rules, automuting, and custom_metrics properties
sso_config/*.py API version updated to 2025-06-11 with validation patterns
monitor/*.py API version updated, added resource_collection, removed location from update, changed to AAZPasswordArg
subscription_status/*.py New command group added for subscription status management
monitored_subscription/*.py New command group for managing monitored subscriptions
HISTORY.rst Release notes added for version 2.1.0

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 29, 2025
@yonzhan yonzhan requested review from jsntcy and kairu-ms October 30, 2025 00:28
@jbhanuchand jbhanuchand changed the title minimised command size Datadog update version 2025-06-11 Oct 31, 2025
@jbhanuchand jbhanuchand requested a review from Copilot October 31, 2025 08:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 3 comments.

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 31, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 31, 2025
@jbhanuchand jbhanuchand requested a review from Copilot October 31, 2025 09:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 3 comments.

@jbhanuchand jbhanuchand requested a review from Copilot October 31, 2025 10:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 3 comments.

@jbhanuchand jbhanuchand requested a review from Copilot October 31, 2025 11:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/datadog/azext_datadog/aaz/latest/datadog/monitor/_update.py:1

  • The 'location' argument has been removed from the update command. This is a breaking change - if users were previously able to update the location of a monitor resource, they will no longer be able to do so. Ensure this is intentional and documented in release notes, as Azure resources typically don't allow location changes after creation.
# --------------------------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants