Added Nginx 2025-03-01-preview (WAF v2) #9325
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| nginx deployment list-default-waf-policy | cmd nginx deployment list-default-waf-policy added |
||
| nginx deployment waf-policy | sub group nginx deployment waf-policy added |
|
Hi @briantkim93, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for NGINX WAF (Web Application Firewall) v2 functionality using the new 2025-03-01-preview API version. The update introduces new commands for managing WAF policies within NGINX deployments and updates the minimum Azure CLI version requirement.
Key changes:
- Introduced WAF policy management commands (create, delete, list, show, update, wait)
- Added new API version 2025-03-01-preview for WAF policy operations
- Updated minimum CLI core version requirement from 2.68.0 to 2.75.0
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/nginx/azext_nginx/tests/latest/test_nginx_scenario.py | Added test coverage for WAF v2 policy operations and updated test data |
| src/nginx/azext_nginx/azext_metadata.json | Updated minimum CLI core version to 2.75.0 |
| src/nginx/azext_nginx/aaz/latest/nginx/deployment/waf_policy/*.py | Implemented WAF policy CRUD operations and wait command |
| src/nginx/azext_nginx/aaz/latest/nginx/deployment/_list_default_waf_policy.py | Added command to list default WAF policies |
| src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuration/_update.py | Removed help text for root_file parameter |
| src/nginx/HISTORY.rst | Updated release notes for version 2.0.0b9 |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @briantkim93 Release SuggestionsModule: nginx
Notes
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9325 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
4 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.