-
Notifications
You must be signed in to change notification settings - Fork 0
updated from API 34 to 35 and added edge-to-edge opt option #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sande11
wants to merge
28
commits into
master
Choose a base branch
from
133-update-android-app-to-target-latest-api-level-and-google-sdks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
updated from API 34 to 35 and added edge-to-edge opt option #134
sande11
wants to merge
28
commits into
master
from
133-update-android-app-to-target-latest-api-level-and-google-sdks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith its floating button
…ogic in search view
… Dialog_font text
… results duplication bug, keyboard not being dismissed, search loading icon stuck on screen, bookmark card cut off, search result tabs being clipped
Changed the text in body fragment to expand when display and font size of the display changes
… rest of the app and subchapter.json to remove a duplicate subchapter title
private const val BUILD_VERSION = 12 private const val PENDO_RELEASE_VERSION = "Oct-25-"
…n' into 133-update-android-app-to-target-latest-api-level-and-google-sdks
…d-app-to-target-latest-api-level-and-google-sdks Revert "updated from API 34 to 35 in TB Guide android UI Updates"
- Bump compileSdk and targetSdk to 36 - Update dependencies to latest versions - Implement edge-to-edge layout in MainActivity - Add status bar background view in activity_main.xml - Add support for 16KB page size in gradle.properties
Updated tab container structure to improve appearance when font size is increased
Added logic to automatically expand collapsed dropdowns, tabs, and details elements that contain search results before performing in-page search. Also added a method to collapse expanded sections when clearing the search. Updated custom_action_bar_title.xml to use wrap_content for height with a minimum height of 56dp for better layout flexibility.
Changed the floating notes button margins and constraint to improve positioning. MarginEnd increased to 25dp, marginBottom added, and constraint now aligns to bottom_toolbar instead of search_view_include.
…app-ui-with-new-figma-design Merge the latest UI updates to API level update branch
Replaces removeLast() with removeAt(recentSearches.lastIndex) to remove the last item from the recent searches list, ensuring compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update android API from 34 to 35
Summary
This PR addresses updates of Android API from 34 to 35 and visual issues that occurred after updating the app to target Android API 35 (Android 15) and It implements the necessary edge-to-edge enforcement opt-out.
Changes Made
Fixed Edge-to-Edge Enforcement Issues
android:windowOptOutEdgeToEdgeEnforcement="true"toTheme.GATBReferenceGuideFiles Modified
app/src/main/res/values/themes.xml/app/build.gradleBefore:
After:
Testing
Future Considerations
Important: The
windowOptOutEdgeToEdgeEnforcementattribute has been removed in Android 16. We have priotized other work (updating UI for TB Guide Android) then later on will update the app to the latest Android 16 and fix layout issues that will follow.