bugfix to kinesis.py when using ThorLabs HDR50/M rotation stage with BSC201 controller #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BSC201 controller
Hi Lachlan, glad you found this useful. Can't really help with the "stale" PR as I haven't received any comments or change requests. However, merging into the main trunk should not be too much of a problem for Git unless that specific line of code has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a copy of PR #46 by mnirkko. I have implemented it against the latest version of pylablib and tested it with hardware in my lab. That previous PR seems stale, so perhaps this is easier to merge into the main trunk.