Skip to content

fixes list_devices for filter_ids=Flase #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes list_devices for filter_ids=Flase #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pylablib/devices/Thorlabs/kinesis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ def _is_thorlabs_id(did):
return re.match(r"^\d{8}$",did[0]) is not None
dids=comm_backend.FT232DeviceBackend.list_resources(desc=True)
if filter_ids:
ids=[did for did in dids if _is_thorlabs_id(did)]
return ids
return [did for did in dids if _is_thorlabs_id(did)]
return dids
def send_comm(self, messageID, param1=0x00, param2=0x00, source=0x01, dest="host"):
"""
Send a message with no associated data.
Expand Down Expand Up @@ -1391,4 +1391,4 @@ def v2i(v, scale=10):
open_loop_out=current_parameters.open_loop_out if open_loop_out is None else open_loop_out
data=struct.pack("<hhhhHHhh",xmin,ymin,xmax,ymax,route,open_loop_out,xgain,ygain)
self._quad_set(0x05,data)
return self.get_output_parameters()
return self.get_output_parameters()