Feat: (Health check) Check `alt_ip` if web domain is not accessible #768

graycraft · 2025-04-20T19:00:03Z

Task check list

Test cases passed
Verbose logging ([Feat] Add "Verbose logging in Console" in developer mode #867): Make “Status updated” at the debug level, everything else at info

Task description

To test this complex algorithm clearly, in the src/config/development.json leave only one list with one entry.
There are 3 possible cases, let's take a look at the example of ADAMANT nodes:

Domain is available, use domain.

{
  "adm": {
    "nodes": {
      "list":[
        {
          "url": "https://debate.adamant.im",
          "alt_ip": "http://95.216.161.113:36666"
        }
      ]
    }
  }
}

Domain is unavailable, try to use IP.

{
  "adm": {
    "nodes": {
      "list":[
        {
          "url": "https://abc.adamant.im",
          "alt_ip": "http://95.216.161.113:36666"
        }
      ]
    }
  }
}

Domain is unavailable, IP is unavailable.

{
  "adm": {
    "nodes": {
      "list":[
        {
          "url": "https://abc.adamant.im",
          "alt_ip": "http://123.123.123.123:36666"
        }
      ]
    }
  }
}

Remember to filter out log messages and leave only console.info

Test cases

url: tauri.adm.im
alt_ip: 154.26.159.245:36666

The application tries a health check (api/node/status) on the domain tauri.adm.im.

a) Domain is accessible

Save this state, and all subsequent requests (both health checks and data requests) go to tauri.adm.im.
The "by domain" status is kept until the page is reloaded or the checkbox is toggled.
If later a health check request fails, the node is considered (temporarily) offline, but health checks continue as before.
This is not a node ban — the node may be temporarily offline.

b) Domain is not accessible

The application tries a health check (api/node/status) on IP 154.26.159.245:36666.
If the IP is accessible, save this state and all subsequent requests go to 154.26.159.245:36666.
The "by IP" status is kept until the page is reloaded or the checkbox is toggled.
If later a health check request fails, the node is considered (temporarily) offline, but health checks continue as before.
This is not a node ban — the node may be temporarily offline.

c) Neither domain nor IP is accessible

We cannot be sure the node is unavailable. It may be a temporary node or internet failure.
There will be no "by domain" or "by IP" status.
Start again from step 1.

…ot available

vercel · 2025-04-20T19:00:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
adamant-im	Ready	Preview	Comment	Oct 27, 2025 3:49pm

github-actions · 2025-04-20T19:02:12Z

Deployed to https://msg-adamant-pr-768.surge.sh 🚀

graycraft · 2025-04-20T19:02:58Z

Feat: (Health check) Check alt_ip if web domain is not accessible

… available

src/lib/nodes/abstract.node.ts

…t type def

dvelikiy · 2025-04-28T12:24:15Z

The logic becomes more complex, it'd be good to write tests for different use-cases.

adamantmm · 2025-05-03T17:45:15Z

@S-FrontendDev @bludnic
Please review

src/lib/nodes/abstract.node.ts

src/lib/nodes/adm/AdmNode.ts

src/lib/nodes/adm/index.ts

src/lib/nodes/abstract.node.ts

src/lib/nodes/eth/EthNode.ts

src/lib/nodes/rate-info-service/RateInfoService.ts

…onnection once per cycle

graycraft · 2025-09-27T22:48:46Z

Test environment: https://adamant-i3cxk32io-adamant-team.vercel.app/options/nodes Console/Network filter: /tauri.adm|159\.245/

Bug: Connection type (domain/IP) is not saved/stored.

Actual logs:

[HealthCheck] Connection via https://tauri.adm.im succeeded (URL: https://tauri.adm.im, IP: http://154.26.159.245:36666).
index-Cj9qkcvN.js:253 [HealthCheck] Node status updated for https://tauri.adm.im. Height: 48942407. Ping: 379. Node is online.
index-Cj9qkcvN.js:253 [HealthCheck] Connection via https://tauri.adm.im succeeded (URL: https://tauri.adm.im, IP: http://154.26.159.245:36666).
index-Cj9qkcvN.js:253 [HealthCheck] Node status updated for https://tauri.adm.im. Height: 48942409. Ping: 1399. Node is online.
index-Cj9qkcvN.js:253 [HealthCheck] Connection via https://tauri.adm.im succeeded (URL: https://tauri.adm.im, IP: http://154.26.159.245:36666).
index-Cj9qkcvN.js:253 [HealthCheck] Node status updated for https://tauri.adm.im. Height: 48942411. Ping: 1249. Node is online.

Expected:

1. Once connected via domain, there will be no more rechecks and message `[HealthCheck] Connection via https://tauri.adm.im succeeded` appear only once.

2. Next, only `[HealthCheck] Node status updated` messages appear in logs.

eee2431

…e (domain/IP) during a session

graycraft · 2025-09-28T11:06:11Z

@adamant-al @adamantmm @S-FrontendDev

The following case has been fixed:

Open /options/nodes page with blocked Tauri node in Developer tools.
HTTP is not allowed.
Both domain (tauri.adm.im) and IP (154.26.159.245:36666) are disabled. Health checks are continue repeating.
Enabled Tauri node in the Developer tools.
Connected by domain.
Blocked Tauri node again in the Developer tools. The application tries to connect by IP (incorrect behavior).

In other words, the final logic is: persistently save the connection type (domain/IP) during a session (until a user refreshes the page or disables/enables the node using the checkbox) for each node after the first successful connection

100cc3f

adamantmm · 2025-10-08T11:46:24Z

@S-FrontendDev

Maybe we should add a small popup under HTTP is not allowed, explaining that this is a browser restriction and that the user can bypass it?

This can be a separate task. For example, add ℹ️: HTTP is not allowed ⟶ HTTP is not allowed ℹ️

fyi
[UX/UI, Enhancement] Small popup for "HTTP is not allowed" #888

adamantmm

@graycraft

Test case failed.

url: tauri.adm.im
alt_ip: 154.26.159.245:36666

The application tries a health check (api/node/status) on the domain tauri.adm.im.

Open Nodes screen
Domain is accessible
Done: Save this state, and all subsequent requests (both health checks and data requests) go to tauri.adm.im.
Block *tauri* in Dev Tools.
Health check request fails, but the node is NOT considered (temporarily) offline, it is shown as "online" with outdated height, then status changed from "online" to "syncing".

Expected in (5):

Health check request fails, the node is considered (temporarily) offline, it is shown as "offline", and not used for app requests.
After node goes back online, it's included in the list of live nodes, and may be "online" or "syncing" depending on its height (as usual).

…if health check fails

graycraft · 2025-10-08T14:29:20Z

@graycraft

Test case failed.

url: tauri.adm.im alt_ip: 154.26.159.245:36666

The application tries a health check (api/node/status) on the domain tauri.adm.im.

1. Open Nodes screen

2. Domain is accessible

3. Done: Save this state, and all subsequent requests (both health checks and data requests) go to tauri.adm.im.

4. Block `*tauri*` in Dev Tools.

5. Health check request fails, but the node is NOT considered (temporarily) offline, it is shown as "online" with outdated height, then status changed from "online" to "syncing".

Expected in (5):

1. Health check request fails, the node is considered (temporarily) offline, it is shown as "offline", and not used for app requests.

2. After node goes back online, it's included in the list of live nodes, and may be "online" or "syncing" depending on its height (as usual).

8993697

S-FrontendDev · 2025-10-08T16:21:50Z

@adamantmm is test passed?

adamantmm · 2025-10-08T16:39:14Z

@adamantmm is test passed?

Yes, it is.

Waiting for "Verbose logging" not to spam in logs, and then we can merge.

… Tools

…ing`

… others at info level

graycraft added 2 commits April 20, 2025 23:17

feat(lib/nodes/abstract.node.ts): request a node by IP if domain is n…

4cc61a5

…ot available

feat(lib/nodes/): request a node by IP if domain is not available

64e79a0

graycraft added the enhancement New feature or request label Apr 20, 2025

graycraft requested review from adamant-al, bludnic and psy21d April 20, 2025 19:00

graycraft self-assigned this Apr 20, 2025

graycraft temporarily deployed to testing April 20, 2025 19:00 — with GitHub Actions Inactive

feat(lib/nodes/eth/EthNode.ts): request a node by IP if domain is not…

3828ade

… available

graycraft temporarily deployed to testing April 21, 2025 21:03 — with GitHub Actions Inactive

vercel bot deployed to Preview April 21, 2025 21:04 View deployment

graycraft marked this pull request as ready for review April 21, 2025 21:08

graycraft requested a review from a team as a code owner April 21, 2025 21:08

bludnic requested changes Apr 22, 2025

View reviewed changes

src/lib/nodes/abstract.node.ts Outdated Show resolved Hide resolved

src/lib/nodes/abstract.node.ts Outdated Show resolved Hide resolved

src/lib/nodes/abstract.node.ts Outdated Show resolved Hide resolved

chore(src/lib/nodes/): import NodeInfo interface instead of explici…

4ce93cb

…t type def

graycraft temporarily deployed to testing April 22, 2025 18:34 — with GitHub Actions Inactive

vercel bot deployed to Preview April 22, 2025 18:36 View deployment

chore(src/lib/nodes/): rename this.alt_ip to this.altIp

259d74c

graycraft temporarily deployed to testing April 22, 2025 18:41 — with GitHub Actions Inactive

vercel bot deployed to Preview April 22, 2025 18:43 View deployment

adamant-al requested review from bludnic and dvelikiy April 24, 2025 08:25

bludnic requested changes May 4, 2025

View reviewed changes

refactor(src/lib/nodes/): remove mapping of endpoint properties

9a5e3af

graycraft temporarily deployed to testing May 12, 2025 16:10 — with GitHub Actions Inactive

chore(src/lib/nodes/abstract.node.ts): log message about successful c…

eee2431

…onnection once per cycle

graycraft temporarily deployed to testing September 27, 2025 22:45 — with GitHub Actions Inactive

vercel bot deployed to Preview September 27, 2025 22:47 View deployment

fix(src/lib/nodes/abstract.node.ts): persistently save connection typ…

100cc3f

…e (domain/IP) during a session

graycraft temporarily deployed to testing September 28, 2025 11:01 — with GitHub Actions Inactive

vercel bot deployed to Preview September 28, 2025 11:03 View deployment

S-FrontendDev requested a review from adamantmm October 6, 2025 15:47

adamantmm requested changes Oct 8, 2025

View reviewed changes

fix(src/lib/nodes/abstract.node.ts): temporaly consider node offline …

8993697

…if health check fails

graycraft temporarily deployed to testing October 8, 2025 14:27 — with GitHub Actions Inactive

vercel bot deployed to Preview October 8, 2025 14:28 View deployment

adamantmm approved these changes Oct 8, 2025

View reviewed changes

adamantmm mentioned this pull request Oct 8, 2025

[Feat, Enhancement] Health-check: Check alt_ip if web domain is not accessible #895

Open

adamantmm linked an issue Oct 8, 2025 that may be closed by this pull request

[Feat, Enhancement] Health-check: Check alt_ip if web domain is not accessible #895

Open

graycraft added 8 commits October 26, 2025 01:02

feat(store/modules/dev-tools): add Vuex store for ADAMANT Development…

1c3ec3d

… Tools

feat(store): add Vuex store for ADAMANT Development Tools

6571301

feat(store/types/root-state): define devTools in root state

57b56e3

feat(store/plugins/localStorage): save devTools state to local storage

edcaed8

feat(src/locales/{en,ru}.json): add translation for `dev_screens.logg…

06e400a

…ing`

feat(views/devScreens/DevScreens): add dropdown for verbose logging

d855d1f

Merge branch 'feat/log-verbosity' into feature/alternative-ip

d36c88e

test(abstract.node.ts): output status update messages at debug level,…

4f50736

… others at info level

graycraft temporarily deployed to testing October 27, 2025 15:47 — with GitHub Actions Inactive

vercel bot deployed to Preview October 27, 2025 15:49 View deployment

Uh oh!

Feat: (Health check) Check alt_ip if web domain is not accessible #768

Are you sure you want to change the base?

Feat: (Health check) Check alt_ip if web domain is not accessible #768

Uh oh!

Conversation

graycraft commented Apr 20, 2025 • edited by dev-adamant-im Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task check list

Task description

Test cases

a) Domain is accessible

b) Domain is not accessible

c) Neither domain nor IP is accessible

Uh oh!

vercel bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graycraft commented Apr 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dvelikiy commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamantmm commented May 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graycraft commented Sep 27, 2025

Uh oh!

graycraft commented Sep 28, 2025

Uh oh!

adamantmm commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamantmm left a comment

Choose a reason for hiding this comment

Uh oh!

graycraft commented Oct 8, 2025

Uh oh!

S-FrontendDev commented Oct 8, 2025

Uh oh!

adamantmm commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Feat: (Health check) Check `alt_ip` if web domain is not accessible #768

Feat: (Health check) Check `alt_ip` if web domain is not accessible #768

graycraft commented Apr 20, 2025 •

edited by dev-adamant-im

Loading

vercel bot commented Apr 20, 2025 •

edited

Loading

github-actions bot commented Apr 20, 2025 •

edited

Loading

dvelikiy commented Apr 28, 2025 •

edited

Loading

adamantmm commented Oct 8, 2025 •

edited

Loading