Base implementation of handleSearch #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankjlin16
requested changes
Oct 22, 2024
Cartier32
force-pushed
the
Feature/4/handle-search
branch
from
12bc79b to
34b791b
Compare
Author
|
Changes resolved, commits squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base implementation of issue 4 is completed. I tested it through a scratch file that calls the method and prints out the array list that is returned then asserting if links match. This implementation only works for indeed.com at this point, was going to focus on more websites but most required sign in and since we are working on a sign in handler currently for indeed I thought it made sense. Tried to annotate with comments as much as possible so let me know if there is anything that is unclear. The logic of the method uses the WebDriver object from Selenium to scrape the given webpage with the given criteria. The WebDriver finds elements of the webpages through HTML, usually XPATH since it is pretty easy to single out elements with that syntax, then interacts with the elements to create the outgoing Array List. Once through all of the generated results the method returns the Array List full of the scraped links. Only issue I was having was the try catch blocks executing a slowly, would rather them not be there but I could not think of a better way to handle those cases.
#4