fix: player no longer bounces when crossing tile boundaries fixes #18 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuawalker3
requested review from
4pt1y,
AwesomeJaith,
Cartier32,
Remi-Godin and
racuna1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #18
Fix issue where player bounced when crossing tile boundaries.
Solution
To solve this issue the player collider was changed to be flat on the bottom and sides and a collision margin was added to the players collider. This change introduced a new bug where there were moments in time when the player could not jump while moving or while touching walls due to how the collider interacted with the sides of tile colliders. This was solved by changing the size of the shape caster generated when the new Character Controller Bundle was created. Scale was decreased from 0.99 to 0.75.
Testing
Tested by running game with PhysicsDebugger plugin, moving character across tile boundaries, and verifying correct force vector response. Moved player against wall, verified no force vector applied while static and jumping