-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(cli): Add preview shortcuts #14574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 58dc27c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14574 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please share with us the end result of the feature? For example, you can share a screenshot. That's essentially the testing part.
The changeset must be changed, and it should be improved. We should describe what shortcuts are now enabled
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
I added a screenshot and updated the changeset with more details. |
|
@jacobdalamb not sure if you noticed, but tests aren't passing anymore. Probably adding the shortcuts causes some regression, so you'd have to look after those |
|
@ematipico just had to update branch |
|
Thank you @jacobdalamb We'll keep the PR here for now as we're close to a minor release. We will merge it for the next one :) |
Changes
Adds Vite's CLI shortcuts to
astro previewResolves #14569
Testing
Docs
astro preview
/cc @withastro/maintainers-docs for feedback!