Skip to content

Conversation

@jacobdalamb
Copy link
Contributor

@jacobdalamb jacobdalamb commented Oct 19, 2025

Changes

Adds Vite's CLI shortcuts to astro preview
Resolves #14569

Testing

CleanShot 2025-10-20 at 08 32 21@2x

Docs

astro preview

/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2025

🦋 Changeset detected

Latest commit: 58dc27c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 19, 2025
@jacobdalamb jacobdalamb changed the title Add preview shortcuts feat: (astro) Add preview shortcuts Oct 19, 2025
@jacobdalamb jacobdalamb changed the title feat: (astro) Add preview shortcuts feat(cli): Add preview shortcuts Oct 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 19, 2025

CodSpeed Performance Report

Merging #14574 will not alter performance

Comparing jacobdalamb:add-preview-shortcuts (58dc27c) with main (cba8cc1)

Summary

✅ 6 untouched

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share with us the end result of the feature? For example, you can share a screenshot. That's essentially the testing part.

The changeset must be changed, and it should be improved. We should describe what shortcuts are now enabled

@jacobdalamb
Copy link
Contributor Author

Can you please share with us the end result of the feature? For example, you can share a screenshot. That's essentially the testing part.

The changeset must be changed, and it should be improved. We should describe what shortcuts are now enabled

I added a screenshot and updated the changeset with more details.

@ematipico
Copy link
Member

@jacobdalamb not sure if you noticed, but tests aren't passing anymore.

Probably adding the shortcuts causes some regression, so you'd have to look after those

@jacobdalamb
Copy link
Contributor Author

@ematipico just had to update branch

@ematipico
Copy link
Member

Thank you @jacobdalamb

We'll keep the PR here for now as we're close to a minor release. We will merge it for the next one :)

@ematipico ematipico added this to the v5.16.0 milestone Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

astro preview won't quit

2 participants