Skip to content

Commit 8bbbb22

Browse files
committed
drop anyhow as a dev dependency
1 parent c3bcebe commit 8bbbb22

File tree

7 files changed

+38
-34
lines changed

7 files changed

+38
-34
lines changed

Cargo.lock

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ tskit-derive = {version = "0.2.0", path = "tskit-derive", optional = true}
2929
chrono = { version = "0.4.40", default-features = false, features = ["now", "std"] , optional = true}
3030

3131
[dev-dependencies]
32-
anyhow = {version = "1.0.86"}
3332
clap = {version = "4.4.6", features = ["derive"]}
3433
serde = {version = "1.0.203", features = ["derive"]}
3534
serde-pickle = "1.1.0"

examples/bincode_metadata.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ fn main() {
1717
ts.dump("with_bincode_metadata.trees", 0).unwrap();
1818
}
1919

20-
fn make_tables() -> anyhow::Result<tskit::TableCollection> {
20+
fn make_tables() -> Result<tskit::TableCollection, tskit::TskitError> {
2121
let mut tables = tskit::TableCollection::new(100.0)?;
2222
let pop0 = tables.add_population()?;
2323
let ind0 = tables.add_individual_with_metadata(
@@ -46,6 +46,6 @@ fn make_tables() -> anyhow::Result<tskit::TableCollection> {
4646
Ok(tables)
4747
}
4848

49-
fn make_treeseq() -> anyhow::Result<tskit::TreeSequence> {
49+
fn make_treeseq() -> Result<tskit::TreeSequence, tskit::TskitError> {
5050
Ok(make_tables()?.tree_sequence(0)?)
5151
}

examples/haploid_wright_fisher.rs

Lines changed: 30 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,35 @@
11
// This is a rust implementation of the example
22
// found in tskit-c
33

4-
use anyhow::Result;
54
use clap::Parser;
65
#[cfg(test)]
76
use rand::distributions::Distribution;
87
use rand::prelude::*;
98
use rand::SeedableRng;
109

10+
#[derive(Debug)]
11+
enum Error {
12+
Tskit(tskit::TskitError),
13+
Message(String),
14+
}
15+
16+
impl From<tskit::TskitError> for Error {
17+
fn from(value: tskit::TskitError) -> Self {
18+
Self::Tskit(value)
19+
}
20+
}
21+
22+
impl std::fmt::Display for Error {
23+
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
24+
match self {
25+
Self::Tskit(e) => write!(f, "{e}"),
26+
Self::Message(m) => write!(f, "{m}"),
27+
}
28+
}
29+
}
30+
31+
impl std::error::Error for Error {}
32+
1133
fn rotate_edges(bookmark: &tskit::types::Bookmark, tables: &mut tskit::TableCollection) {
1234
let num_edges = tables.edges().num_rows().as_usize();
1335
let left =
@@ -32,15 +54,15 @@ fn simulate(
3254
num_generations: i32,
3355
simplify_interval: i32,
3456
update_bookmark: bool,
35-
) -> Result<tskit::TreeSequence> {
57+
) -> Result<tskit::TreeSequence, Error> {
3658
if popsize == 0 {
37-
return Err(anyhow::Error::msg("popsize must be > 0"));
59+
return Err(Error::Message("popsize must be > 0".to_string()));
3860
}
3961
if num_generations == 0 {
40-
return Err(anyhow::Error::msg("num_generations must be > 0"));
62+
return Err(Error::Message("num_generations must be > 0".to_string()));
4163
}
4264
if simplify_interval == 0 {
43-
return Err(anyhow::Error::msg("simplify_interval must be > 0"));
65+
return Err(Error::Message("simplify_interval must be > 0".to_string()));
4466
}
4567
let mut tables = tskit::TableCollection::new(1.0)?;
4668

@@ -72,10 +94,10 @@ fn simulate(
7294
let child = tables.add_node(0, bt, -1, -1)?;
7395
let left_parent = parents
7496
.get(parent_picker.sample(&mut rng))
75-
.ok_or_else(|| anyhow::Error::msg("invalid left_parent index"))?;
97+
.ok_or_else(|| Error::Message("invalid left_parent index".to_string()))?;
7698
let right_parent = parents
7799
.get(parent_picker.sample(&mut rng))
78-
.ok_or_else(|| anyhow::Error::msg("invalid right_parent index"))?;
100+
.ok_or_else(|| Error::Message("invalid right_parent index".to_string()))?;
79101
let breakpoint = breakpoint_generator.sample(&mut rng);
80102
tables.add_edge(0., breakpoint, *left_parent, child)?;
81103
tables.add_edge(breakpoint, 1.0, *right_parent, child)?;
@@ -120,7 +142,7 @@ struct SimParams {
120142
bookmark: bool,
121143
}
122144

123-
fn main() -> Result<()> {
145+
fn main() -> Result<(), Error> {
124146
let params = SimParams::parse();
125147
let treeseq = simulate(
126148
params.seed,

examples/json_metadata.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ fn main() {
1717
ts.dump("with_json_metadata.trees", 0).unwrap();
1818
}
1919

20-
fn make_tables() -> anyhow::Result<tskit::TableCollection> {
20+
fn make_tables() -> Result<tskit::TableCollection, tskit::TskitError> {
2121
let mut tables = tskit::TableCollection::new(100.0)?;
2222
let pop0 = tables.add_population()?;
2323
let ind0 = tables.add_individual_with_metadata(
@@ -46,6 +46,6 @@ fn make_tables() -> anyhow::Result<tskit::TableCollection> {
4646
Ok(tables)
4747
}
4848

49-
fn make_treeseq() -> anyhow::Result<tskit::TreeSequence> {
50-
Ok(make_tables()?.tree_sequence(0)?)
49+
fn make_treeseq() -> Result<tskit::TreeSequence, tskit::TskitError> {
50+
make_tables()?.tree_sequence(0)
5151
}

examples/manual_metadata_encoding.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ fn main() {
7979
ts.dump("with_manual_metadata.trees", 0).unwrap();
8080
}
8181

82-
fn make_tables() -> anyhow::Result<tskit::TableCollection> {
82+
fn make_tables() -> Result<tskit::TableCollection, tskit::TskitError> {
8383
let mut tables = tskit::TableCollection::new(100.0)?;
8484
let pop0 = tables.add_population()?;
8585
let ind0 = tables.add_individual_with_metadata(
@@ -108,8 +108,8 @@ fn make_tables() -> anyhow::Result<tskit::TableCollection> {
108108
Ok(tables)
109109
}
110110

111-
fn make_treeseq() -> anyhow::Result<tskit::TreeSequence> {
112-
Ok(make_tables()?.tree_sequence(0)?)
111+
fn make_treeseq() -> Result<tskit::TreeSequence, tskit::TskitError> {
112+
make_tables()?.tree_sequence(0)
113113
}
114114

115115
#[test]

src/error.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -107,14 +107,4 @@ mod test {
107107
panic!();
108108
}
109109
}
110-
111-
#[test]
112-
fn test_anyhow_compatability() {
113-
fn foo() -> anyhow::Result<crate::TableCollection> {
114-
let tables = crate::TableCollection::new(1.0)?;
115-
Ok(tables)
116-
}
117-
118-
let _ = foo().unwrap();
119-
}
120110
}

0 commit comments

Comments
 (0)