Apply feedback

Author: Seldaek

session/configuring_ttl.rst

@@ -46,15 +46,12 @@ You need to pass the TTL in the options array of the session handler you are usi
     .. code-block:: php
 
         // config/services.php
-        use Symfony\Component\DependencyInjection\Reference;
         use Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler;
 
-        $container
-            ->register(RedisSessionHandler::class)
-            ->setArguments([
-                new Reference('Redis'),
-                ['ttl' => 600],
-            ]);
+        $services
+            ->set(RedisSessionHandler::class)
+            ->arg('$redis', new Reference('Redis'))
+            ->arg('$options', ['ttl' => 600]);
 
 
 .. _configuring-the-TTL-dynamically-at-runtime:
@@ -79,13 +76,13 @@ The callback will be called right before the session is written.
             Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler:
                 arguments:
                     - '@Redis'
-                    - { 'ttl': !closure ['@my.ttl.handler'] }
+                    - { 'ttl': !closure '@my.ttl.handler' }
              
             my.ttl.handler:
                 class: Some\InvokableClass # some class with an __invoke() method
                 arguments:
                     # Inject whatever dependencies you need to be able to resolve a TTL for the current session
-                    - @security
+                    - '@security'
 
     .. code-block:: xml
 
@@ -94,26 +91,28 @@ The callback will be called right before the session is written.
             <service id="Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler">
                 <argument type="service" id="Redis"/>
                 <argument type="collection">
-                    <argument key="ttl">600</argument>
+                    <argument key="ttl" type="closure" id="my.ttl.handler"/>
                 </argument>
             </service>
+            <!-- some class with an __invoke() method -->
+            <service id="my.ttl.handler" class="Some\InvokableClass">
+                <!-- Inject whatever dependencies you need to be able to resolve a TTL for the current session -->
+                <argument type="service" id="security"/>
+            </service>
         </services>
 
     .. code-block:: php
 
         // config/services.php
-        use Symfony\Component\DependencyInjection\Reference;
         use Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler;
 
-        $container
-            ->register(RedisSessionHandler::class)
-            ->setArguments([
-                new Reference('Redis'),
-                ['ttl' => new Reference('my.ttl.handler')],
-            ]);
-        
-        $container
+        $services
+            ->set(RedisSessionHandler::class)
+            ->arg('$redis', new Reference('Redis'))
+            ->arg('$options', ['ttl' => closure(service('my.ttl.handler'))]);
+
+        $services
             // some class with an __invoke() method
-            ->register('my.ttl.handler', 'Some\InvokableClass')
+            ->set('my.ttl.handler', 'Some\InvokableClass')
             // Inject whatever dependencies you need to be able to resolve a TTL for the current session
-            ->addArgument(new Reference('security')); 
+            ->arg('$security', service('security'));