[python] Don't set a default logging stream handler #12640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbroon
force-pushed
the
python-logging
branch
from
dbb6a74 to
1b530d5
Compare
Contributor
Author
|
Not sure who the appropriate people are to seek review from... @ewaostrowska, @djankows @daniel-kmiecik are you able to help? |
Merged
Member
|
Hi @nickbroon, thanks for your contribution, the changes from this PR were addressed in #12649 and merged, thus closing this one. |
Contributor
Author
|
Fantastic, thanks Damian. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of the generated python library setting a default stream handler logger, which can subvert an applications intention and goes against python coding best practice described in #8263.
The solution takes the same approach as that in OpenAPITools/openapi-generator#480
Closes: #8263