refactor(git): rewrite internal command line API (ruifm#71)

* refactor(git): better function API

* perf(ci): add version.txt for please-release

Author: linrongbin16

lua/gitlinker.lua

@@ -184,17 +184,12 @@ local function make_link_data(range)
         vim.inspect(remote)
     )
 
-    --- @type JobResult
     local remote_url_result = git.get_remote_url(remote)
-    if not remote_url_result:has_out() then
-        remote_url_result:print_err(
-            "failed to get remote url by remote '" .. remote .. "'"
-        )
+    if not remote_url_result then
         return nil
     end
     logger.debug(
-        "|make_link_data| remote_url_result(%s):%s",
-        vim.inspect(type(remote_url_result)),
+        "|make_link_data| remote_url_result:%s",
         vim.inspect(remote_url_result)
     )
 
@@ -254,14 +249,8 @@ local function make_link_data(range)
         )
     end
 
-    local remote_url = remote_url_result.stdout[1]
-    logger.debug(
-        "[make_link_data] remote_url(%s):%s",
-        vim.inspect(type(remote_url)),
-        vim.inspect(remote_url)
-    )
     return new_linker(
-        remote_url,
+        remote_url_result,
         rev,
         buf_path_on_root,
         range.lstart,

lua/gitlinker/git.lua

@@ -71,29 +71,29 @@ end
 
 --- @package
 --- @return JobResult
-local function get_remote()
+local function _get_remote()
     local result = cmd({ "git", "remote" })
-    logger.debug(
-        "|git.get_remote| result(%s):%s",
-        vim.inspect(type(result)),
-        vim.inspect(result)
-    )
+    logger.debug("|git._get_remote| result:%s", vim.inspect(result))
     return result
 end
 
 --- @param remote string
---- @return JobResult
+--- @return string?
 local function get_remote_url(remote)
     assert(remote, "remote cannot be nil")
     local result = cmd({ "git", "remote", "get-url", remote })
     logger.debug(
-        "|git.get_remote_url| remote(%s):%s, result(%s):%s",
-        vim.inspect(type(remote)),
+        "|git.get_remote_url| remote:%s, result:%s",
         vim.inspect(remote),
-        vim.inspect(type(result)),
         vim.inspect(result)
     )
-    return result
+    if not result:has_out() then
+        result:print_err(
+            "failed to get remote url by remote '" .. remote .. "'"
+        )
+        return nil
+    end
+    return result.stdout[1]
 end
 
 --- @package
@@ -250,10 +250,10 @@ end
 local function get_branch_remote()
     -- origin/upstream
     --- @type JobResult
-    local remote_result = get_remote()
+    local remote_result = _get_remote()
 
     if type(remote_result.stdout) ~= "table" or #remote_result.stdout == 0 then
-        remote_result:print_err("git repository has no remote")
+        remote_result:print_err("git repo has no remote")
         return nil
     end
 
@@ -262,7 +262,6 @@ local function get_branch_remote()
     end
 
     -- origin/linrongbin16/add-rule2
-    --- @type JobResult
     local upstream_branch_result = get_rev_name("@{u}")
     if not upstream_branch_result:has_out() then
         upstream_branch_result:print_err("git branch has no remote")

version.txt

@@ -0,0 +1 @@
+0.1.0