fixed warnings coming from phasar code (#799)

mxHuber · fabianbs96 · web-flow · commit 23ea6b97ed19 · 2025-11-08T13:30:34.000+01:00
* fixed warnings coming from phasar code

* Fixed error + missed Z3 warnings

* changed tmpnam for mkstemp + maybe unused flags

* removed mkstemp, print ESG to llvm::errs()

---------

Co-authored-by: Fabian Schiebel &lt;52407375+fabianbs96@users.noreply.github.com&gt;
diff --git a/include/phasar/DataFlow/IfdsIde/DefaultEdgeFunctionSingletonCache.h b/include/phasar/DataFlow/IfdsIde/DefaultEdgeFunctionSingletonCache.h
@@ -46,7 +46,7 @@ class DefaultEdgeFunctionSingletonCacheImpl
 
   void insert(const EdgeFunctionTy *EF, const void *Mem) override {
     assert(EF != nullptr);
-    auto [It, Inserted] = Cache.try_emplace(EF, Mem);
+    [[maybe_unused]] auto [It, Inserted] = Cache.try_emplace(EF, Mem);
     assert(Inserted);
   }
 
diff --git a/include/phasar/DataFlow/IfdsIde/Solver/IterativeIDESolver.h b/include/phasar/DataFlow/IfdsIde/Solver/IterativeIDESolver.h
@@ -569,7 +569,7 @@ class IterativeIDESolver
 
     auto AtInstruction = NodeCompressor[AtInstructionId];
 
-    auto FunId = [=] {
+    auto FunId = [&] {
       if constexpr (EnableJumpFunctionGC != JumpFunctionGCMode::Disabled) {
 
         auto Ret = FunCompressor.getOrInsert(ICFG.getFunctionOf(AtInstruction));
diff --git a/include/phasar/DataFlow/PathSensitivity/PathSensitivityManagerMixin.h b/include/phasar/DataFlow/PathSensitivity/PathSensitivityManagerMixin.h
@@ -89,18 +89,9 @@ class PathSensitivityManagerMixin {
       if (LLVM_UNLIKELY(!Nod)) {
         llvm::errs() << "Invalid Instruction-FlowFact pair. Only use those "
                         "pairs that are part of the IDE analysis results!\n";
-        llvm::errs() << "Fatal error occurred. Writing ESG to temp file...\n";
-        llvm::errs().flush();
-
-        auto FileName = std::string(tmpnam(nullptr)) + "-explicitesg-err.dot";
-
-        {
-          std::error_code EC;
-          llvm::raw_fd_ostream ROS(FileName, EC);
-          ESG.printAsDot(ROS);
-        }
+        llvm::errs() << "Fatal error occurred. Printing ESG ...\n";
 
-        llvm::errs() << "> ESG written to " << FileName << '\n';
+        ESG.printAsDot(llvm::errs());
         llvm::errs().flush();
 
         abort();
diff --git a/lib/PhasarLLVM/ControlFlow/GlobalCtorsDtorsModel.cpp b/lib/PhasarLLVM/ControlFlow/GlobalCtorsDtorsModel.cpp
@@ -30,8 +30,7 @@ static void insertGlobalCtorsDtorsImpl(MapTy &Into, const llvm::Module &M,
     return;
   }
 
-  if (const auto *FunArray =
-          llvm::dyn_cast<llvm::ArrayType>(Gtors->getValueType())) {
+  if (llvm::isa<llvm::ArrayType>(Gtors->getValueType())) {
     if (const auto *ConstFunArray =
             llvm::dyn_cast<llvm::ConstantArray>(Gtors->getInitializer())) {
       for (const auto &Op : ConstFunArray->operands()) {
diff --git a/lib/PhasarLLVM/ControlFlow/SVFGCache.cpp b/lib/PhasarLLVM/ControlFlow/SVFGCache.cpp
@@ -94,7 +94,7 @@ static bool shouldKeepInst(const llvm::Instruction *Inst,
   const auto *ValTy = Val->getType();
   bool ValPtr = ValTy->isPointerTy();
 
-  if (const auto *Call = llvm::dyn_cast<llvm::CallBase>(Inst)) {
+  if (llvm::isa<llvm::CallBase>(Inst)) {
     if (llvm::isa<llvm::GlobalValue>(Val)) {
       return true;
     }
diff --git a/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEGeneralizedLCA/ConstantHelper.cpp b/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEGeneralizedLCA/ConstantHelper.cpp
@@ -32,8 +32,7 @@ bool psr::glca::isConstant(const llvm::Value *Val) {
     auto *Op1 = Gep->getOperand(0); // op1 is pointer-operand
     if (auto *Glob = llvm::dyn_cast<llvm::GlobalVariable>(Op1);
         Glob && Glob->hasInitializer()) {
-      if (auto *Cdat =
-              llvm::dyn_cast<llvm::ConstantDataArray>(Glob->getInitializer())) {
+      if (llvm::isa<llvm::ConstantDataArray>(Glob->getInitializer())) {
         return true; // it is definitely a const string
       }
     }
diff --git a/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEGeneralizedLCA/IDEGeneralizedLCA.cpp b/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEGeneralizedLCA/IDEGeneralizedLCA.cpp
@@ -61,7 +61,7 @@ IDEGeneralizedLCA::getNormalFlowFunction(IDEGeneralizedLCA::n_t Curr,
     const auto *ValueOp = Store->getValueOperand();
     if (isConstant(ValueOp)) {
       // llvm::outs() << "==> constant store" << std::endl;
-      return lambdaFlow([=](IDEGeneralizedLCA::d_t Source)
+      return lambdaFlow([this, PointerOp](IDEGeneralizedLCA::d_t Source)
                             -> std::set<IDEGeneralizedLCA::d_t> {
         // llvm::outs() << "##> normal lambdaFlow for: " <<
         // llvmIRToString(curr)
@@ -131,7 +131,8 @@ IDEGeneralizedLCA::getNormalFlowFunction(IDEGeneralizedLCA::n_t Curr,
     bool NoneConst = !LeftConst && !RightConst;
 
     return lambdaFlow(
-        [=](IDEGeneralizedLCA::d_t Source) -> std::set<IDEGeneralizedLCA::d_t> {
+        [this, Lhs, Rhs, BothConst, NoneConst, Curr](
+            IDEGeneralizedLCA::d_t Source) -> std::set<IDEGeneralizedLCA::d_t> {
           if (Source == Lhs || Source == Rhs ||
               ((BothConst || NoneConst) && isZeroValue(Source))) {
             return {Source, Curr};
diff --git a/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.cpp b/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.cpp
@@ -35,7 +35,7 @@ IDEIIAFlowFact::IDEIIAFlowFact(
 }
 
 IDEIIAFlowFact IDEIIAFlowFact::create(const llvm::Value *BaseVal) {
-  if (const auto *Alloca = llvm::dyn_cast<llvm::AllocaInst>(BaseVal)) {
+  if (llvm::isa<llvm::AllocaInst>(BaseVal)) {
     return {BaseVal};
   }
   if (const auto *Gep = llvm::dyn_cast<llvm::GetElementPtrInst>(BaseVal)) {
diff --git a/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDELinearConstantAnalysis.cpp b/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDELinearConstantAnalysis.cpp
@@ -347,8 +347,7 @@ IDELinearConstantAnalysis::getNormalFlowFunction(n_t Curr, n_t /*Succ*/) {
     /// We are extracting the result of a BinaryOpIntrinsic
     /// The first parameter holds the resulting integer if
     /// no error occured during the operation
-    if (const auto *BinIntrinsic =
-            llvm::dyn_cast<llvm::BinaryOpIntrinsic>(Agg)) {
+    if (llvm::isa<llvm::BinaryOpIntrinsic>(Agg)) {
       if (Extract->getType()->isIntegerTy()) {
         return generateFlow(Curr, Agg);
       }
diff --git a/lib/PhasarLLVM/DataFlow/PathSensitivity/LLVMPathConstraints.cpp b/lib/PhasarLLVM/DataFlow/PathSensitivity/LLVMPathConstraints.cpp
@@ -609,8 +609,7 @@ auto LLVMPathConstraints::getGEPInstAsZ3(const llvm::GetElementPtrInst *GEP)
         .first->second;
   }
   // some other pointer, we can treat those as integers
-  if (const auto *PointerTy =
-          llvm::dyn_cast<llvm::PointerType>(GEP->getPointerOperandType())) {
+  if (llvm::isa<llvm::PointerType>(GEP->getPointerOperandType())) {
     auto PointerConst = Z3Ctx->bv_const(Name.c_str(), 64);
     return Z3Expr.try_emplace(GEP, ConstraintAndVariables{PointerConst, {GEP}})
         .first->second;
diff --git a/lib/PhasarLLVM/DataFlow/PathSensitivity/Z3BasedPathSensitivityManager.cpp b/lib/PhasarLLVM/DataFlow/PathSensitivity/Z3BasedPathSensitivityManager.cpp
@@ -29,7 +29,7 @@ z3::expr Z3BasedPathSensitivityManagerBase::filterOutUnreachableNodes(
   Ctx.Visited.resize(graph_traits_t::size(RevDAG));
   Ctx.NodeConstraints.resize(graph_traits_t::size(RevDAG), Ctx.True);
 
-  size_t TotalNumEdges = 0;
+  [[maybe_unused]] size_t TotalNumEdges = 0;
   for (auto I : graph_traits_t::vertices(RevDAG)) {
     TotalNumEdges += graph_traits_t::outDegree(RevDAG, I);
   }
@@ -55,7 +55,7 @@ z3::expr Z3BasedPathSensitivityManagerBase::filterOutUnreachableNodes(
 
     llvm::SmallVector<z3::expr> Ys;
 
-    for (auto Iter = graph_traits_t::outEdges(RevDAG, Vtx).begin();
+    for (const auto *Iter = graph_traits_t::outEdges(RevDAG, Vtx).begin();
          Iter != graph_traits_t::outEdges(RevDAG, Vtx).end();) {
       // NOLINTNEXTLINE(readability-qualified-auto, llvm-qualified-auto)
       auto It = Iter++;
@@ -103,7 +103,7 @@ z3::expr Z3BasedPathSensitivityManagerBase::filterOutUnreachableNodes(
 
   z3::expr Ret = LPC.getContext().bool_val(false);
 
-  for (auto Iter = graph_traits_t::roots(RevDAG).begin();
+  for (const auto *Iter = graph_traits_t::roots(RevDAG).begin();
        Iter != graph_traits_t::roots(RevDAG).end();) {
     // NOLINTNEXTLINE(readability-qualified-auto, llvm-qualified-auto)
     auto It = Iter++;
@@ -322,7 +322,7 @@ class ConstraintPathFilter {
 
   ConstraintPathFilter(LLVMPathConstraints &LPC,
                        const z3::expr &AdditionalConstraint,
-                       size_t *CompletedCtr) noexcept
+                       const size_t *CompletedCtr) noexcept
       : LPC(LPC), Solver(LPC.getContext()), CompletedCtr(*CompletedCtr) {
     Solver.add(AdditionalConstraint);
     Solver.push();
@@ -450,7 +450,7 @@ class ConstraintPathFilter {
   size_t Ctr = 0;
   size_t RejectedCtr = 0;
   size_t IsValidCalls = 0;
-  size_t &CompletedCtr;
+  [[maybe_unused]] const size_t &CompletedCtr;
 };
 
 auto Z3BasedPathSensitivityManagerBase::filterAndFlattenRevDag(
diff --git a/lib/PhasarLLVM/Passes/GeneralStatisticsAnalysis.cpp b/lib/PhasarLLVM/Passes/GeneralStatisticsAnalysis.cpp
@@ -105,8 +105,7 @@ GeneralStatistics GeneralStatisticsAnalysis::runOnModule(llvm::Module &M) {
         }
 
         // check for alloca instruction for possible types
-        if (const llvm::AllocaInst *Alloc =
-                llvm::dyn_cast<llvm::AllocaInst>(&I)) {
+        if (llvm::isa<llvm::AllocaInst>(&I)) {
           // do not add allocas from llvm internal functions
           Stats.AllocaInstructions.insert(&I);
           ++Stats.AllocationSites;
diff --git a/lib/PhasarLLVM/Pointer/FilteredAliasesUtils.h b/lib/PhasarLLVM/Pointer/FilteredAliasesUtils.h
@@ -57,7 +57,7 @@ inline LLVM_LIBRARY_VISIBILITY bool mustNoalias(const llvm::Value *P1,
     if (llvm::isa<llvm::AllocaInst>(P2) || isConstantGlobalValue(Glob1)) {
       return true;
     }
-    if (const auto *Glob2 = llvm::dyn_cast<llvm::GlobalValue>(P2)) {
+    if (llvm::isa<llvm::GlobalValue>(P2)) {
       return true; // approximation
     }
   } else if (const auto *Glob2 = llvm::dyn_cast<llvm::GlobalValue>(P2)) {
diff --git a/lib/PhasarLLVM/Utils/Annotation.cpp b/lib/PhasarLLVM/Utils/Annotation.cpp
@@ -29,7 +29,7 @@ namespace psr {
 
 VarAnnotation::VarAnnotation(const llvm::CallBase *AnnotationCall) noexcept
     : AnnotationCall(AnnotationCall) {
-  auto *Callee = AnnotationCall->getCalledFunction();
+  [[maybe_unused]] auto *Callee = AnnotationCall->getCalledFunction();
   assert(Callee && Callee->hasName() &&
          (Callee->getName() == "llvm.var.annotation" ||
           Callee->getName().startswith("llvm.ptr.annotation")));
diff --git a/lib/Utils/PAMM.cpp b/lib/Utils/PAMM.cpp
@@ -62,8 +62,8 @@ void PAMM::startTimer(llvm::StringRef TimerId) {
 }
 
 void PAMM::resetTimer(llvm::StringRef TimerId) {
-  bool InRunningTimers = RunningTimer.erase(TimerId);
-  bool InStoppedTimers = StoppedTimer.erase(TimerId);
+  [[maybe_unused]] bool InRunningTimers = RunningTimer.erase(TimerId);
+  [[maybe_unused]] bool InStoppedTimers = StoppedTimer.erase(TimerId);
 
   assert((InRunningTimers && !InStoppedTimers) ||
          (!InRunningTimers && InStoppedTimers) &&
@@ -149,7 +149,8 @@ std::string PAMM::getPrintableDuration(uint64_t Duration) {
 }
 
 void PAMM::regCounter(llvm::StringRef CounterId, unsigned IntialValue) {
-  auto [It, Inserted] = Counter.try_emplace(CounterId, IntialValue);
+  [[maybe_unused]] auto [It, Inserted] =
+      Counter.try_emplace(CounterId, IntialValue);
   assert(Inserted && "regCounter failed due to an invalid counter id");
 }
 
@@ -214,7 +215,7 @@ PAMM::getSumCount(std::initializer_list<llvm::StringRef> CounterIds) {
 }
 
 void PAMM::regHistogram(llvm::StringRef HistogramId) {
-  auto [It, Inserted] = Histogram.try_emplace(HistogramId);
+  [[maybe_unused]] auto [It, Inserted] = Histogram.try_emplace(HistogramId);
   assert(Inserted && "failed to register new histogram due to an invalid id");
 }
 
diff --git a/tools/example-tool/myphasartool.cpp b/tools/example-tool/myphasartool.cpp
@@ -32,7 +32,7 @@ int main(int Argc, const char **Argv) {
     return 1;
   }
 
-  if (const auto *F = HA.getProjectIRDB().getFunctionDefinition("main")) {
+  if (HA.getProjectIRDB().getFunctionDefinition("main")) {
     // print type hierarchy
     HA.getTypeHierarchy().print();
     // print points-to information

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class DefaultEdgeFunctionSingletonCacheImpl`
`46`	`46`
`47`	`47`	`void insert(const EdgeFunctionTy EF, const void Mem) override {`
`48`	`48`	`assert(EF != nullptr);`
`49`		`- auto [It, Inserted] = Cache.try_emplace(EF, Mem);`
	`49`	`+ [[maybe_unused]] auto [It, Inserted] = Cache.try_emplace(EF, Mem);`
`50`	`50`	`assert(Inserted);`
`51`	`51`	`}`
`52`	`52`
Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,7 @@ static void insertGlobalCtorsDtorsImpl(MapTy &Into, const llvm::Module &M,`
`30`	`30`	`return;`
`31`	`31`	`}`
`32`	`32`
`33`		`- if (const auto *FunArray =`
`34`		`- llvm::dyn_cast<llvm::ArrayType>(Gtors->getValueType())) {`
	`33`	`+ if (llvm::isa<llvm::ArrayType>(Gtors->getValueType())) {`
`35`	`34`	`if (const auto *ConstFunArray =`
`36`	`35`	`llvm::dyn_cast<llvm::ConstantArray>(Gtors->getInitializer())) {`
`37`	`36`	`for (const auto &Op : ConstFunArray->operands()) {`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ static bool shouldKeepInst(const llvm::Instruction *Inst,`
`94`	`94`	`const auto *ValTy = Val->getType();`
`95`	`95`	`bool ValPtr = ValTy->isPointerTy();`
`96`	`96`
`97`		`- if (const auto *Call = llvm::dyn_cast<llvm::CallBase>(Inst)) {`
	`97`	`+ if (llvm::isa<llvm::CallBase>(Inst)) {`
`98`	`98`	`if (llvm::isa<llvm::GlobalValue>(Val)) {`
`99`	`99`	`return true;`
`100`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,7 @@ bool psr::glca::isConstant(const llvm::Value *Val) {`
`32`	`32`	`auto *Op1 = Gep->getOperand(0); // op1 is pointer-operand`
`33`	`33`	`if (auto *Glob = llvm::dyn_cast<llvm::GlobalVariable>(Op1);`
`34`	`34`	`Glob && Glob->hasInitializer()) {`
`35`		`- if (auto *Cdat =`
`36`		`- llvm::dyn_cast<llvm::ConstantDataArray>(Glob->getInitializer())) {`
	`35`	`+ if (llvm::isa<llvm::ConstantDataArray>(Glob->getInitializer())) {`
`37`	`36`	`return true; // it is definitely a const string`
`38`	`37`	`}`
`39`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ IDEIIAFlowFact::IDEIIAFlowFact(`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`IDEIIAFlowFact IDEIIAFlowFact::create(const llvm::Value *BaseVal) {`
`38`		`- if (const auto *Alloca = llvm::dyn_cast<llvm::AllocaInst>(BaseVal)) {`
	`38`	`+ if (llvm::isa<llvm::AllocaInst>(BaseVal)) {`
`39`	`39`	`return {BaseVal};`
`40`	`40`	`}`
`41`	`41`	`if (const auto *Gep = llvm::dyn_cast<llvm::GetElementPtrInst>(BaseVal)) {`