fix: optional typing

Author: faretek1

src/site/base.ts

@@ -3,7 +3,7 @@ import * as urls from '../utils/urls'
 
 export class BaseSiteComponent {
     protected session?: session.Session;
-    constructor(params: session.Session | undefined | {
+    constructor(params?: session.Session | {
         session?: session.Session
     }) {
         if (params instanceof session.Session || params === undefined) {

src/site/project.ts

@@ -23,7 +23,7 @@ export class PartialProject extends base.BaseSiteComponent {
             params.id = 0;
         }
 
-        super({session: params.session});
+        super(params.session);
 
         this.id = params.id;
         this.title = params.title;

src/site/session.ts

@@ -38,7 +38,7 @@ export class Session extends base.BaseSiteComponent{
             params.password = '';
         }
 
-        super({});
+        super();
         this.session = this;
 
         this.id = params.id;
@@ -115,9 +115,11 @@ export class Session extends base.BaseSiteComponent{
 export function decode_session_id(session_id: string): [Record<string, string>, Date] {
     const [p1, p2] = session_id.split(':');
 
+    expect(p2).toBeDefined();
+
     return [
         JSON.parse(zlib.inflateSync(Buffer.from(p1 + '==', 'base64url')).toString()),
-        new Date(commons.b62_decode(p2) * 1000)
+        new Date(commons.b62_decode(p2!) * 1000)
     ];
 }
 

src/site/user.ts

@@ -4,15 +4,15 @@ import * as session from './session';
 import * as urls from '../utils/urls'
 
 export class User extends base.BaseSiteComponent {
-    id?: number;
-    name?: string;
+    id: number | undefined;
+    name: string | undefined;
 
     constructor(params: {
         name?: string;
         id?: number;
         session?: session.Session
     }) {
-        super({session: params.session});
+        super(params.session);
 
         this.id = params.id;
         this.name = params.name;

tsconfig.json

@@ -25,7 +25,7 @@
 
     // Stricter Typechecking Options
     "noUncheckedIndexedAccess": true,
-    "exactOptionalPropertyTypes": true,
+    "exactOptionalPropertyTypes": false,
 
     // Style Options
     // "noImplicitReturns": true,