Skip to content

Conversation

@synarete
Copy link
Collaborator

Get ready for next release by updating to most recent golang and relevant tools.

Upgrade project to support the latest two version of golang.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Update to latest golang version (2025-08-12).

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Upgrade to latest golangci-lint version.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Use latest github actions: setup-go@v6 and checkout@v5.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, I'm happy to approve - however some projects have been switching to use hashes to be me more secure against possible future malicious versions:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

Since you're touching a lot of these now it might be worth adopting that practice too, but I won't insist on it at this time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting -- I was not aware. Will dig into it and see how it goes...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed another commit with explicit git-hash instead of tags. Not sure if this is the proper/recommended way. @phlogistonjohn WDYT ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me.

Switching to explicit hash; be more secure against possible future
malicious versions[1].

[1] https://docs.github.com/en/actions/reference/
          security/secure-use#using-third-party-actions

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@synarete synarete merged commit a4360c6 into samba-in-kubernetes:main Nov 12, 2025
8 checks passed
@synarete synarete deleted the ss-project-updates-pre-release-0.8 branch November 12, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants