-
Notifications
You must be signed in to change notification settings - Fork 5
project updates pre release 0.8 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project updates pre release 0.8 #33
Conversation
Upgrade project to support the latest two version of golang. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Update to latest golang version (2025-08-12). Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Upgrade to latest golangci-lint version. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Use latest github actions: setup-go@v6 and checkout@v5. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
.github/workflows/main.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-go@v5 | ||
| - uses: actions/setup-go@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, I'm happy to approve - however some projects have been switching to use hashes to be me more secure against possible future malicious versions:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions
Since you're touching a lot of these now it might be worth adopting that practice too, but I won't insist on it at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting -- I was not aware. Will dig into it and see how it goes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed another commit with explicit git-hash instead of tags. Not sure if this is the proper/recommended way. @phlogistonjohn WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me.
Switching to explicit hash; be more secure against possible future malicious versions[1]. [1] https://docs.github.com/en/actions/reference/ security/secure-use#using-third-party-actions Signed-off-by: Shachar Sharon <ssharon@redhat.com>
phlogistonjohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anoopcs9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Get ready for next release by updating to most recent golang and relevant tools.