Remove configurable font weight of links inside Alert #577

adamkudrna · adamkudrna · commit 72081fa337f5 · 2024-12-06T19:31:33.000+01:00
Links in `Alert` now inherit the font weight which is consistent
with other links in React UI.
diff --git a/src/components/Alert/Alert.module.scss b/src/components/Alert/Alert.module.scss
@@ -25,8 +25,8 @@
         padding: theme.$padding;
     }
 
-    .close,
-    .icon {
+    .icon,
+    .close {
         height: settings.$min-height;
         color: var(--rui-local-foreground-color);
     }
@@ -46,11 +46,8 @@
         line-height: settings.$line-height;
     }
 
-    .message :is(a, strong) {
-        font-weight: theme.$emphasis-font-weight;
-    }
-
     .message strong {
+        font-weight: theme.$emphasis-font-weight;
         color: var(--rui-local-foreground-color);
     }
 
diff --git a/src/components/Alert/README.md b/src/components/Alert/README.md
@@ -201,14 +201,14 @@ helps to improve its accessibility.
 
 ### Common Theming Options
 
-| Custom Property                                      | Description                                                  |
-|------------------------------------------------------|--------------------------------------------------------------|
-| `--rui-Alert__padding`                               | Padding between border and message                           |
-| `--rui-Alert__font-weight`                           | Message font weight                                          |
-| `--rui-Alert__border-width`                          | Border width                                                 |
-| `--rui-Alert__border-radius`                         | Corner radius                                                |
-| `--rui-Alert__emphasis__font-weight`                 | Font weight of text emphasised with `<strong>`               |
-| `--rui-Alert__stripe__width`                         | Width of the border at the start of the Alert                |
+| Custom Property                      | Description                                    |
+|--------------------------------------|------------------------------------------------|
+| `--rui-Alert__padding`               | Padding between border and message             |
+| `--rui-Alert__font-weight`           | Message font weight                            |
+| `--rui-Alert__border-width`          | Border width                                   |
+| `--rui-Alert__border-radius`         | Corner radius                                  |
+| `--rui-Alert__emphasis__font-weight` | Font weight of text emphasised with `<strong>` |
+| `--rui-Alert__stripe__width`         | Width of the border at the start of the Alert  |
 
 ### Theming Variants
 

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,8 @@`
`25`	`25`	`padding: theme.$padding;`
`26`	`26`	`}`
`27`	`27`
`28`		`- .close,`
`29`		`- .icon {`
	`28`	`+ .icon,`
	`29`	`+ .close {`
`30`	`30`	`height: settings.$min-height;`
`31`	`31`	`color: var(--rui-local-foreground-color);`
`32`	`32`	`}`
`@@ -46,11 +46,8 @@`
`46`	`46`	`line-height: settings.$line-height;`
`47`	`47`	`}`
`48`	`48`
`49`		`- .message :is(a, strong) {`
`50`		`- font-weight: theme.$emphasis-font-weight;`
`51`		`- }`
`52`		`-`
`53`	`49`	`.message strong {`
	`50`	`+ font-weight: theme.$emphasis-font-weight;`
`54`	`51`	`color: var(--rui-local-foreground-color);`
`55`	`52`	`}`
`56`	`53`