Skip to content

Conversation

@chasefarmer-pixee
Copy link
Contributor

Simple patch to implement the base_url property method for the OpenAIResponsesModel subclass.

@DouweM
Copy link
Collaborator

DouweM commented Oct 29, 2025

@chasefarmer-pixee Thanks Chase! To fix coverage you can add/modify a test like this one:

def test_init():
m = OpenAIChatModel('gpt-4o', provider=OpenAIProvider(api_key='foobar'))
assert m.base_url == 'https://api.openai.com/v1/'
assert m.client.api_key == 'foobar'
assert m.model_name == 'gpt-4o'

@DouweM
Copy link
Collaborator

DouweM commented Oct 31, 2025

@chasefarmer-pixee Please have a look at the failing lint job; I suggest running make format before committing :)

@DouweM DouweM changed the title fixup: implement base_url prop method for OpenAIResponsesModel Implement OpenAIResponsesModel.base_url property Nov 3, 2025
@DouweM DouweM enabled auto-merge (squash) November 3, 2025 17:36
@DouweM DouweM merged commit c1d49d4 into pydantic:main Nov 3, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants