🐛 Vertical tabs correctly follow fullscreen state

They used to (1) initialize to the oppisite value as the fullscreen value and (2) allow reveal when content goes into fullscreen

Author: trickypr

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Update uBlock to `1.52.2`
 
+### Fixed
+
+- Vertical tabs will correctly follow fullscreen state
+
 ## 1.0.0-a.81
 
 ### Changed
@@ -49,7 +53,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Vertical tabs: Open new tab w/ clipboard contents on space middle click
 - The new tab & close tab buttons can now be hidden
 
-### Changedv
+### Changed
 
 - Vertical tabs: New tab button no longer has text
 - Partial `:has` support is enabled (this is intended for userchrome use only)

src/browser/base/content/browser-verticaltabs.js

@@ -147,7 +147,16 @@ var VerticalTabs = {
 
     addEventListener('fullscreen', this, true)
     window.addEventListener('mousemove', (e) => {
-      if (!window.fullScreen || !this.verticalTabsEnabled) return
+      // We can ignore mouse move events when:
+      // - We are not in fullscreen
+      // - Vertical tabs are disabled (this logic is handled elsewher )
+      // - We are in fullscreen because of a document element (e.g. a video)
+      if (
+        !window.fullScreen ||
+        !this.verticalTabsEnabled ||
+        document.fullscreenElement
+      )
+        return
       const tabsToolbar = this.tabsToolbar
       if (!tabsToolbar) return
 
@@ -243,7 +252,7 @@ var VerticalTabs = {
   handleEvent(event) {
     switch (event.type) {
       case 'fullscreen':
-        if (!window.fullScreen) this.fsMethods.collapse()
+        if (window.fullScreen) this.fsMethods.collapse()
         else this.fsMethods.expand()
         break
     }