Use deque for buffer

Author: Anton Shabouta

Buffer.cpp

@@ -13,15 +13,11 @@
 Buffer::Buffer() noexcept {
 }
 
-Buffer::Buffer(const std::vector<unsigned char> &_buffer) noexcept:
-    buffer(_buffer) {
-}
-
 void Buffer::clear() noexcept {
     buffer.clear();
 }
 
-void Buffer::write(char * str, long length) noexcept {
+void Buffer::write(char * str, unsigned long length) noexcept {
     buffer.insert(buffer.end(), str, str + length);
 }
 
@@ -45,13 +41,7 @@ void Buffer::merge(const Buffer &other) noexcept {
 }
 
 std::string Buffer::bytes() const noexcept {
-    std::stringstream stream;
-
-    unsigned long long size = buffer.size();
-    for (unsigned long long i = 0; i < size; ++i)
-        stream << buffer[i];
-
-    return stream.str();
+    return std::string(buffer.begin(), buffer.end());
 }
 
 std::string Buffer::flush() noexcept {

Buffer.hpp

@@ -8,19 +8,18 @@
  */
 
 #pragma once
-#include <vector>
-#include <sstream>
+#include <deque>
+#include <string>
 #include <exception>
 
 struct BufferOverflow : public std::exception {};
 
 class Buffer {
 public:
     Buffer() noexcept;
-    Buffer(const std::vector<unsigned char>&) noexcept;
 
     void clear() noexcept;
-    void write(char * str, long length) noexcept;
+    void write(char * str, unsigned long length) noexcept;
     void discard(unsigned long long n);
 
     unsigned long long size() const noexcept;
@@ -102,5 +101,5 @@ class Buffer {
 
     ~Buffer();
 private:
-    std::vector<unsigned char> buffer;
+    std::deque<unsigned char> buffer;
 };

buffer.cc

@@ -720,7 +720,7 @@ static zend_function_entry buffer_object_methods[] = {
 };
 
 static zend_object* buffer_object_create(zend_class_entry *ce) {
-    buffer_object *objval = (buffer_object*) ecalloc(1, sizeof(buffer_object) + zend_object_properties_size(ce));
+    buffer_object *objval = (buffer_object*) emalloc(sizeof(buffer_object) + zend_object_properties_size(ce));
 
     zend_object* ret = buffer_object_to_zend_object(objval);