Merge pull request #5 from timlegge/main

Release 0.11

Author: timlegge

Changes

@@ -2,6 +2,14 @@ Revision history for Crypt-OpenSSL-SignCSR.
 
 {{$NEXT}}
 
+0.11 -- Tue Jul 18 19:27:54 ADT 2023
+
+    - daa5dd9 Increment version for release
+    - 3a09798 Remove undocumented sigopts from sign()
+    - 4295e6b Better regex for more openssl versions
+    - a32ff18 Find out the version of OpenSSL
+    - 2a21fa4 v0.10
+
 0.10 -- Sat Jul 08 21:24:27 ADT 2023
 
     - 7272fa3 Increment the version for a release

Makefile.PL

@@ -70,7 +70,7 @@ my %WriteMakefileArgs = (
     "File::Slurper" => "0.012",
     "File::Which" => 0
   },
-  "VERSION" => "0.10",
+  "VERSION" => "0.11",
   "test" => {
     "TESTS" => "t/*.t"
   }

README.md

@@ -15,14 +15,14 @@ my $signer = Crypt::OpenSSL::SignCSR->new(
                                   format  => $format, # Output format "text" or "pem" (default)
                               });
 my $cert   = $signer->sign(
-                              $request, # CRS in PEM format
+                              $request, # CSR in PEM format
                           );
 
 my $ret = $signer->set_days(3650);
 my $ret = $signer->set_format("text");
 my $ret = $signer->set_days("SHA512");
 
-$cert   = $signer->sign( $request ); # CRS in PEM format
+$cert   = $signer->sign( $request ); # CSR in PEM format
 ```
 
 # DESCRIPTION

SignCSR.xs

@@ -552,13 +552,12 @@ IV set_days(self, IV days)
 
         RETVAL
 
-SV * sign(self, request_SV, sigopts)
+SV * sign(self, request_SV)
     HV * self;
     SV * request_SV;
 
     PREINIT:
         EVP_MD_CTX *mctx;
-        STACK_OF(OPENSSL_STRING) *sigopts = NULL;
 
     CODE:
 
@@ -752,9 +751,9 @@ SV * sign(self, request_SV, sigopts)
 
         // Sign the new certificate
 #if OPENSSL_API_COMPAT >= 30101
-        if (mctx != NULL && do_sign_init(mctx, private_key, digestname, sigopts) > 0)
+        if (mctx != NULL && do_sign_init(mctx, private_key, digestname, NULL) > 0)
 #else
-        if (mctx != NULL && do_sign_init(mctx, private_key, md, sigopts) > 0)
+        if (mctx != NULL && do_sign_init(mctx, private_key, md, NULL) > 0)
 #endif
             rv = (X509_sign_ctx(x, mctx) > 0);
 

lib/Crypt/OpenSSL/SignCSR.pm

@@ -7,7 +7,7 @@ use warnings;
 
 require Exporter;
 
-our $VERSION  = "0.10";
+our $VERSION  = "0.11";
 
 our @ISA = qw(Exporter);
 
@@ -43,14 +43,14 @@ Crypt::OpenSSL::SignCSR - Sign a Certificate Signing Request in XS.
                                     format  => $format, # Output format "text" or "pem" (default)
                                 });
   my $cert   = $signer->sign(
-                                $request, # CRS in PEM format
+                                $request, # CSR in PEM format
                             );
 
   my $ret = $signer->set_days(3650);
   my $ret = $signer->set_format("text");
   my $ret = $signer->set_days("SHA512");
 
-  $cert   = $signer->sign( $request ); # CRS in PEM format
+  $cert   = $signer->sign( $request ); # CSR in PEM format
 
 =head1 DESCRIPTION
 

t/002-create-cert-from-csr.t

@@ -72,7 +72,7 @@ bczN2A==
 -----END CERTIFICATE REQUEST-----
 CERTREQUEST
 
-my $cert = $signer->sign($request, '');
+my $cert = $signer->sign($request);
 
 my $certfile = tempfile();
 my ($certfh, $certfilename) = tempfile();
@@ -85,7 +85,7 @@ eval {
     $result = `$openssl x509 -in $certfilename -text`;
 };
 
-like($result, qr/Issuer: C = CA, O = XML::Sig, OU = perl/, "Certificate - Issuer OK");
+like($result, qr/Issuer:.*XML::Sig.*perl/, "Certificate - Issuer OK");
 like($result, qr/Signature Algorithm: sha512WithRSAEncryption/, "Certificate - Signature OK");
 
 ok($signer->get_days() eq 365, "Days were set successfully");

t/003-openssl-crypt-pkcs10.t

@@ -72,7 +72,7 @@ my $signer = Crypt::OpenSSL::SignCSR->new(
 
 isa_ok($signer, "Crypt::OpenSSL::SignCSR");
 
-my $cert = $signer->sign($request, '');
+my $cert = $signer->sign($request);
 
 my $certfile = tempfile();
 my ($certfh, $certfilename) = tempfile();
@@ -88,7 +88,7 @@ eval {
 
 unlink $certfilename;
 
-like($result, qr/Issuer: C = CA, ST = New Brunswick, O = XML::Sig, OU = perl/, "Certificate - Issuer OK");
+like($result, qr/Issuer:.*XML::Sig.*perl/, "Certificate - Issuer OK");
 like($result, qr/Signature Algorithm: sha512WithRSAEncryption/, "Certificate - Signature OK");
 
 done_testing